linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>,
	Paul Moore <paul@paul-moore.com>
Cc: Steve Grubb <sgrubb@redhat.com>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-audit@redhat.com
Subject: Re: [PATCH 8/8] ima: Differentiate auditing policy rules from "audit" actions
Date: Wed, 30 May 2018 18:41:16 -0400	[thread overview]
Message-ID: <1527720076.3534.84.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <b9b37328-2977-39fe-e3d2-822144dce6f1@linux.vnet.ibm.com>

On Wed, 2018-05-30 at 18:15 -0400, Stefan Berger wrote:
> On 05/30/2018 06:00 PM, Mimi Zohar wrote:
> > On Wed, 2018-05-30 at 17:49 -0400, Stefan Berger wrote:
> >> So the other choice is to only keep patches 1,2, 6, and 7, so leave most
> >> of the integrity audit messages untouched. Then only create a different
> >> format for the new AUDIT_INTEGRITY_POLICY_RULE (current 8/8) that shares
> >> (for consistency reasons) the same format with the existing integrity
> >> audit messages but also misses tty= and exe= ?
> > Another option would be for the new AUDIT_INTEGRITY_POLICY_RULE to
> > call audit_log_task_info() similar to what ima_audit_measurement()
> > does.
> 
> Right. [That would mean keep 1,2, 7 and modify 8.] Is that the best 
> solution?

Yes, I think so.  Calling audit_log_task_info() will only add the
"exe=" and "tty=" to the new AUDIT_INTEGRITY_POLICY_RULE.

  reply	other threads:[~2018-05-30 22:41 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 20:10 [PATCH 0/8] IMA: work on audit records produced by IMA Stefan Berger
2018-05-24 20:10 ` [PATCH 1/8] ima: Call audit_log_string() rather than logging it untrusted Stefan Berger
2018-05-29 20:29   ` Paul Moore
2018-05-24 20:10 ` [PATCH 2/8] ima: Use audit_log_format() rather than audit_log_string() Stefan Berger
2018-05-29 20:31   ` Paul Moore
2018-05-24 20:11 ` [PATCH 3/8] audit: Implement audit_log_tty() Stefan Berger
2018-05-29 21:07   ` Paul Moore
2018-05-30 19:46     ` Stefan Berger
2018-05-24 20:11 ` [PATCH 4/8] audit: Allow others to call audit_log_d_path_exe() Stefan Berger
2018-05-29 21:18   ` Paul Moore
2018-05-24 20:11 ` [PATCH 5/8] integrity: Add exe= and tty= before res= to integrity audits Stefan Berger
2018-05-29 21:19   ` Paul Moore
2018-05-29 21:35     ` Steve Grubb
2018-05-29 21:47       ` Paul Moore
2018-05-29 22:58         ` Mimi Zohar
2018-05-30 13:04           ` Mimi Zohar
2018-05-30 21:15             ` Paul Moore
2018-05-30 12:17     ` Stefan Berger
2018-05-30 21:14       ` Paul Moore
2018-05-24 20:11 ` [PATCH 6/8] integrity: Factor out common part of integrity_audit_msg() Stefan Berger
2018-05-29 21:32   ` Steve Grubb
2018-05-30 13:04     ` Stefan Berger
2018-05-24 20:11 ` [PATCH 7/8] ima: Do not audit if CONFIG_INTEGRITY_AUDIT is not set Stefan Berger
2018-05-24 20:11 ` [PATCH 8/8] ima: Differentiate auditing policy rules from "audit" actions Stefan Berger
2018-05-29 21:30   ` Steve Grubb
     [not found]     ` <2d5baf73-755b-dc82-a778-25a3cd22989a@linux.vnet.ibm.com>
2018-05-30 15:15       ` Steve Grubb
2018-05-30 15:25         ` Stefan Berger
2018-05-30 16:27           ` Steve Grubb
2018-05-30 19:54             ` Stefan Berger
2018-05-30 21:24               ` Paul Moore
2018-05-30 21:49                 ` Stefan Berger
2018-05-30 22:00                   ` Mimi Zohar
2018-05-30 22:15                     ` Stefan Berger
2018-05-30 22:41                       ` Mimi Zohar [this message]
2018-05-30 23:54                   ` Paul Moore
2018-05-30 12:49   ` Richard Guy Briggs
2018-05-30 12:55     ` Steve Grubb
2018-05-30 13:08     ` Stefan Berger
2018-05-30 21:22       ` Paul Moore
2018-05-30 21:38         ` Stefan Berger
2018-05-30 23:34           ` Richard Guy Briggs
2018-06-01 20:00             ` Stefan Berger
2018-06-01 20:13               ` Paul Moore
2018-06-01 20:21                 ` Paul Moore
2018-06-01 20:50                 ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527720076.3534.84.camel@linux.vnet.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=sgrubb@redhat.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).