From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Matthew Garrett <mjg59@google.com>, linux-integrity@vger.kernel.org
Subject: Re: [USER] [PATCH 1/2] Remove hardcoding of SHA1 in EVM signatures
Date: Wed, 13 Jun 2018 09:41:42 -0400 [thread overview]
Message-ID: <1528897302.3880.1.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180417225601.6965-1-mjg59@google.com>
On Tue, 2018-04-17 at 15:56 -0700, Matthew Garrett wrote:
> @@ -1033,7 +1041,13 @@ static int calc_evm_hmac(const char *file, const char *keyfile, unsigned char *h
> goto out;
> }
>
> - err = !HMAC_Init_ex(pctx, evmkey, sizeof(evmkey), EVP_sha1(), NULL);
> + md = EVP_get_digestbyname(params.hash_algo);
HMAC is still limited to sha1.
> + if (!md) {
> + log_err("EVP_get_digestbyname() failed\n");
> + goto out;
> + }
> +
> + err = !HMAC_Init_ex(pctx, evmkey, sizeof(evmkey), md, NULL);
> if (err) {
> log_err("HMAC_Init() failed\n");
> goto out;
next prev parent reply other threads:[~2018-06-13 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 22:56 [USER] [PATCH 1/2] Remove hardcoding of SHA1 in EVM signatures Matthew Garrett
2018-04-17 22:56 ` [USER] [PATCH 2/2] Add security.apparmor to the set of extended attributes used by EVM Matthew Garrett
2018-06-12 23:42 ` Mimi Zohar
2018-06-14 19:43 ` Matthew Garrett
2018-06-14 20:41 ` Mimi Zohar
2018-07-01 20:28 ` Mimi Zohar
2018-04-18 12:13 ` [USER] [PATCH 1/2] Remove hardcoding of SHA1 in EVM signatures Mimi Zohar
2018-06-13 13:41 ` Mimi Zohar [this message]
2018-06-14 19:42 ` Matthew Garrett
2018-06-22 20:24 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528897302.3880.1.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).