From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Matthew Garrett <mjg59@google.com>
Cc: linux-integrity@vger.kernel.org, linux-crypto@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH V3 1/2] evm: Don't deadlock if a crypto algorithm is unavailable
Date: Wed, 13 Jun 2018 09:50:13 -0400 [thread overview]
Message-ID: <1528897813.3880.4.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180613063303.ftphuca3bagwx3dk@gondor.apana.org.au>
On Wed, 2018-06-13 at 14:33 +0800, Herbert Xu wrote:
> On Fri, Jun 08, 2018 at 02:57:42PM -0700, Matthew Garrett wrote:
> > When EVM attempts to appraise a file signed with a crypto algorithm the
> > kernel doesn't have support for, it will cause the kernel to trigger a
> > module load. If the EVM policy includes appraisal of kernel modules this
> > will in turn call back into EVM - since EVM is holding a lock until the
> > crypto initialisation is complete, this triggers a deadlock. Add a
> > CRYPTO_NOLOAD flag and skip module loading if it's set, and add that flag
> > in the EVM case in order to fail gracefully with an error message
> > instead of deadlocking.
> >
> > Signed-off-by: Matthew Garrett <mjg59@google.com>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks! This patch and "evm: Allow non-SHA1 digital signatures" are
now queued in the next-integrity-queued branch.
Mimi
next prev parent reply other threads:[~2018-06-13 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 21:57 Support additional signature types in EVM Matthew Garrett
2018-06-08 21:57 ` [PATCH V3 1/2] evm: Don't deadlock if a crypto algorithm is unavailable Matthew Garrett
2018-06-12 17:43 ` Matthew Garrett
2018-06-13 6:33 ` Herbert Xu
2018-06-13 13:50 ` Mimi Zohar [this message]
2018-06-08 21:57 ` [PATCH V3 2/2] evm: Allow non-SHA1 digital signatures Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528897813.3880.4.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox