From: Mimi Zohar <zohar@linux.ibm.com>
To: "James Bottomley" <James.Bottomley@HansenPartnership.com>,
"Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>,
"Peter Hüwe" <PeterHuewe@gmx.de>
Cc: Calvin Owens <calvinowens@fb.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH] tpm: Make timeout logic simpler and more robust
Date: Tue, 12 Mar 2019 14:32:00 -0400 [thread overview]
Message-ID: <1552415520.24794.87.camel@linux.ibm.com> (raw)
In-Reply-To: <1552410856.3083.28.camel@HansenPartnership.com>
On Tue, 2019-03-12 at 10:14 -0700, James Bottomley wrote:
> > > However, I am saying we should root cause this problem rather than
> > > take a blind shot at the apparent timeout complexity. My timeout
> > > instability is definitely related to the polling adjustments, so
> > > it's not unreasonable to think Facebooks might be as well.
> >
> > James, I thought Peter sent you a tis "debug" tool to help you debug
> > the problem you're seeing. Whatever happened?
https://patchwork.kernel.org/patch/10520247/#22107607
>
> No, not seen one. I have tried to debug the problem, but it's really
> odd: my TPM is a polled nuvoton (so no irq line). If you poll the data
> ready bit on my TPM too often, it simply drops off the bus and every
> TPM operation after that times out. The only way to recover is to
> reboot.
>
> James
>
next prev parent reply other threads:[~2019-03-12 18:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 23:54 [PATCH] tpm: Make timeout logic simpler and more robust Calvin Owens
2019-03-12 0:27 ` James Bottomley
2019-03-12 12:50 ` Jarkko Sakkinen
2019-03-12 14:42 ` James Bottomley
2019-03-12 15:39 ` Jarkko Sakkinen
2019-03-12 19:41 ` Calvin Owens
2019-03-12 16:59 ` Mimi Zohar
2019-03-12 17:14 ` James Bottomley
2019-03-12 18:32 ` Mimi Zohar [this message]
2019-03-12 19:37 ` Calvin Owens
2019-03-12 12:36 ` Jarkko Sakkinen
2019-03-12 16:56 ` Mimi Zohar
2019-03-12 14:55 ` Jarkko Sakkinen
2019-03-12 17:04 ` Mimi Zohar
2019-03-12 20:08 ` Calvin Owens
2019-03-12 20:56 ` Mimi Zohar
2019-03-13 13:22 ` Jarkko Sakkinen
2019-03-13 13:23 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552415520.24794.87.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=PeterHuewe@gmx.de \
--cc=arnd@arndb.de \
--cc=calvinowens@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=kernel-team@fb.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).