From: Mimi Zohar <zohar@linux.ibm.com>
To: Matthew Garrett <matthewgarrett@google.com>,
linux-integrity@vger.kernel.org
Cc: zohar@linux.vnet.ibm.com, prsriva02@gmail.com,
bauerman@linux.ibm.com, roberto.sassu@huawei.com,
Matthew Garrett <mjg59@google.com>
Subject: Re: [PATCH V2] IMA: Allow profiles to define the desired IMA template
Date: Tue, 28 May 2019 14:37:06 -0400 [thread overview]
Message-ID: <1559068626.4139.23.camel@linux.ibm.com> (raw)
In-Reply-To: <1558704680.3977.15.camel@linux.ibm.com>
Hi Matthew,
Below is one additional comment.
On Fri, 2019-05-24 at 09:31 -0400, Mimi Zohar wrote:
> > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> > index 357edd140c09..f23069d9e43d 100644
> > --- a/security/integrity/ima/ima_main.c
> > +++ b/security/integrity/ima/ima_main.c
>
> > @@ -275,7 +276,9 @@ static int process_measurement(struct file *file, const struct cred *cred,
> > goto out_locked;
> > }
> >
> > - template_desc = ima_template_desc_current();
> > + if (!template_desc)
> > + template_desc = ima_template_desc_current();
This should be moved into ima_match_policy(), so that a valid template
is always returned from ima_get_action().
thanks,
Mimi
>
prev parent reply other threads:[~2019-05-28 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 18:18 [PATCH V2] IMA: Allow profiles to define the desired IMA template Matthew Garrett
2019-05-24 9:29 ` Roberto Sassu
2019-05-28 19:31 ` Matthew Garrett
2019-05-24 13:31 ` Mimi Zohar
2019-05-28 18:37 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559068626.4139.23.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=mjg59@google.com \
--cc=prsriva02@gmail.com \
--cc=roberto.sassu@huawei.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).