Re: [PATCH v5 06/11] ima-evm-utils: Start converting find_keyid to use EVP_PKEY API

[Mimi Zohar <zohar@linux.ibm.com>]

On Wed, 2019-06-19 at 18:43 +0300, Vitaly Chikunov wrote:
> Mimi,
> 
> On Wed, Jun 19, 2019 at 08:26:30AM -0400, Mimi Zohar wrote:
> > On Tue, 2019-06-18 at 16:56 +0300, Vitaly Chikunov wrote:
> > > New find_keyid_pkey() accepts EVP_PKEY. Old find_keyid() calls
> > > find_keyid_pkey(), but still return RSA key.
> > > 
> > > Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> > 
> > With titles starting with "Start converting", it leaves me wondering
> > whether these patches are bisect safe.  Does this patch make
> > find_keyid() a wrapper for find_keyid_pkey()?
> 
> Yes.
> 
> > Do all callers of find_keyid() continue to work properly?
> 
> Yes.
> 
> > If so, why are there other changes in this patch?
> 
> There is no other changes beside stated in description.

Are the changes from read_pub_key() to read_pub_pkey() and
calc_keyid_v2() to calc_pkeyid_v2() needed for making find_keyid() a
wrapper for find_keyid_pkey()?

> 
> > If you haven't already, please make sure that after each patch is
> > applied, the code not only compiles cleanly, but works properly.
> 
> Yes, they compile and work properly after each patch.

thanks!

Mimi