From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D06C43613 for ; Thu, 20 Jun 2019 13:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88951206E0 for ; Thu, 20 Jun 2019 13:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbfFTNlH (ORCPT ); Thu, 20 Jun 2019 09:41:07 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:21500 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726391AbfFTNlH (ORCPT ); Thu, 20 Jun 2019 09:41:07 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5KDXZfu022649 for ; Thu, 20 Jun 2019 09:41:06 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2t8ajvt3k5-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 20 Jun 2019 09:41:05 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Jun 2019 14:41:03 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 20 Jun 2019 14:41:02 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5KDf1dt39780588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Jun 2019 13:41:01 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 29D254204B; Thu, 20 Jun 2019 13:41:01 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 836C842047; Thu, 20 Jun 2019 13:41:00 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.109.247]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 20 Jun 2019 13:41:00 +0000 (GMT) Subject: Re: [PATCH v5 06/11] ima-evm-utils: Start converting find_keyid to use EVP_PKEY API From: Mimi Zohar To: Vitaly Chikunov Cc: Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org Date: Thu, 20 Jun 2019 09:40:49 -0400 In-Reply-To: <1561036909.4525.29.camel@linux.ibm.com> References: <20190618135623.6861-1-vt@altlinux.org> <20190618135623.6861-7-vt@altlinux.org> <1560947190.3975.23.camel@linux.ibm.com> <20190619154339.e3kjc3niahwng64h@altlinux.org> <1560962810.3975.57.camel@linux.ibm.com> <20190620010713.wfmkjkf3fprgc3h6@altlinux.org> <1561036909.4525.29.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19062013-0028-0000-0000-0000037C0E0F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19062013-0029-0000-0000-0000243C20B2 Message-Id: <1561038049.4525.32.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-20_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906200102 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 2019-06-20 at 09:21 -0400, Mimi Zohar wrote: > Hi Vitaly, > > > > > > If so, why are there other changes in this patch? > > > > > > > > There is no other changes beside stated in description. > > > > > > Are the changes from read_pub_key() to read_pub_pkey() and > > > calc_keyid_v2() to calc_pkeyid_v2() needed for making find_keyid() a > > > wrapper for find_keyid_pkey()? > > > > Of course. `entry->key' now have different type. If we keep old type > > (RSA) where will be nothing to wrap. > > The question wasn't if the changes in init_public_keys() need to be > made, the question is its correlation to find_keyid().  Unlesss I'm > missing something, find_keyid() is only called by verify_hash_v2(), > not calc_keyid_v2(). Ah, the list of keys needs to be in the appropriate format.  Perhaps add that info in the patch description. Mimi