* Re: linux-next: Tree for Jun 26 (security/integrity/ima/) [not found] <20190626231617.1e858da3@canb.auug.org.au> @ 2019-06-26 18:35 ` Randy Dunlap 2019-06-27 13:02 ` Mimi Zohar 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2019-06-26 18:35 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, linux-integrity, Mimi Zohar, Dmitry Kasatkin, linux-security-module On 6/26/19 6:16 AM, Stephen Rothwell wrote: > Hi all, > > The sparc64 builds are broken in this tree, sorry. > > Changes since 20190625: > on x86_64: 11 warnings like this one (in a randconfig build): CC security/integrity/ima/ima_fs.o In file included from ../security/integrity/ima/ima.h:25:0, from ../security/integrity/ima/ima_fs.c:26: ../security/integrity/ima/../integrity.h:170:18: warning: ‘struct key_acl’ declared inside parameter list [enabled by default] struct key_acl *acl) ^ ../security/integrity/ima/../integrity.h:170:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jun 26 (security/integrity/ima/) 2019-06-26 18:35 ` linux-next: Tree for Jun 26 (security/integrity/ima/) Randy Dunlap @ 2019-06-27 13:02 ` Mimi Zohar 2019-06-27 13:29 ` David Howells 0 siblings, 1 reply; 4+ messages in thread From: Mimi Zohar @ 2019-06-27 13:02 UTC (permalink / raw) To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List, David Howells Cc: Linux Kernel Mailing List, linux-integrity, Dmitry Kasatkin, linux-security-module [Cc'ing David Howells] On Wed, 2019-06-26 at 11:35 -0700, Randy Dunlap wrote: > On 6/26/19 6:16 AM, Stephen Rothwell wrote: > > Hi all, > > > > The sparc64 builds are broken in this tree, sorry. > > > > Changes since 20190625: > > > > on x86_64: > > 11 warnings like this one (in a randconfig build): > > CC security/integrity/ima/ima_fs.o > In file included from ../security/integrity/ima/ima.h:25:0, > from ../security/integrity/ima/ima_fs.c:26: > ../security/integrity/ima/../integrity.h:170:18: warning: ‘struct key_acl’ declared inside parameter list [enabled by default] > struct key_acl *acl) > ^ > ../security/integrity/ima/../integrity.h:170:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] David, CONFIG_INTEGRITY_SIGNATURE is dependent on KEYS being enabled, but the stub functions are not. There's now a dependency on key_acl(). Mimi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jun 26 (security/integrity/ima/) 2019-06-27 13:02 ` Mimi Zohar @ 2019-06-27 13:29 ` David Howells 2019-06-27 15:08 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: David Howells @ 2019-06-27 13:29 UTC (permalink / raw) To: Mimi Zohar Cc: dhowells, Randy Dunlap, Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, linux-integrity, Dmitry Kasatkin, linux-security-module Mimi Zohar <zohar@linux.ibm.com> wrote: > > CC security/integrity/ima/ima_fs.o > > In file included from ../security/integrity/ima/ima.h:25:0, > > from ../security/integrity/ima/ima_fs.c:26: > > ../security/integrity/ima/../integrity.h:170:18: warning: ‘struct key_acl’ declared inside parameter list [enabled by default] > > struct key_acl *acl) > > ^ > > ../security/integrity/ima/../integrity.h:170:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > > David, CONFIG_INTEGRITY_SIGNATURE is dependent on KEYS being enabled, > but the stub functions are not. There's now a dependency on > key_acl(). I added a forward declaration for struct key_acl into security/integrity/integrity.h as you can see here: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/diff/security/integrity/integrity.h?h=keys-acl&id=75ce113a1d56880e5abd37fa664ea9af399d2bcd which might not have made it into linux-next before you used it. David ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jun 26 (security/integrity/ima/) 2019-06-27 13:29 ` David Howells @ 2019-06-27 15:08 ` Randy Dunlap 0 siblings, 0 replies; 4+ messages in thread From: Randy Dunlap @ 2019-06-27 15:08 UTC (permalink / raw) To: David Howells, Mimi Zohar Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, linux-integrity, Dmitry Kasatkin, linux-security-module On 6/27/19 6:29 AM, David Howells wrote: > Mimi Zohar <zohar@linux.ibm.com> wrote: > >>> CC security/integrity/ima/ima_fs.o >>> In file included from ../security/integrity/ima/ima.h:25:0, >>> from ../security/integrity/ima/ima_fs.c:26: >>> ../security/integrity/ima/../integrity.h:170:18: warning: ‘struct key_acl’ declared inside parameter list [enabled by default] >>> struct key_acl *acl) >>> ^ >>> ../security/integrity/ima/../integrity.h:170:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] >> >> David, CONFIG_INTEGRITY_SIGNATURE is dependent on KEYS being enabled, >> but the stub functions are not. There's now a dependency on >> key_acl(). > > I added a forward declaration for struct key_acl into > security/integrity/integrity.h as you can see here: > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/diff/security/integrity/integrity.h?h=keys-acl&id=75ce113a1d56880e5abd37fa664ea9af399d2bcd > > which might not have made it into linux-next before you used it. No problem in linux-next 20190627. Thanks. -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-27 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190626231617.1e858da3@canb.auug.org.au>
2019-06-26 18:35 ` linux-next: Tree for Jun 26 (security/integrity/ima/) Randy Dunlap
2019-06-27 13:02 ` Mimi Zohar
2019-06-27 13:29 ` David Howells
2019-06-27 15:08 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).