From: Mimi Zohar <zohar@linux.ibm.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: linux-integrity@vger.kernel.org
Subject: Re: [PATCH 2/2] ima_evm_utils: limit duplicate "Failed to open keyfile" messages
Date: Wed, 17 Jul 2019 09:23:34 -0400 [thread overview]
Message-ID: <1563369814.4539.290.camel@linux.ibm.com> (raw)
In-Reply-To: <20190716214948.6ycejuln6q376ngc@altlinux.org>
Vitaly,
On Wed, 2019-07-17 at 00:49 +0300, Vitaly Chikunov wrote:
> > EVP_PKEY *read_pub_pkey(const char *keyfile, int x509)
> > {
> > FILE *fp;
> > X509 *crt = NULL;
> > EVP_PKEY *pkey = NULL;
> > + int found;
> >
> > if (!keyfile)
> > return NULL;
> >
> > fp = fopen(keyfile, "r");
> > if (!fp) {
> > - log_err("Failed to open keyfile: %s\n", keyfile);
> > + found = lookup_keyfile_name(keyfile);
> > + if (!found)
> > + log_err("Failed to open keyfile: %s\n", keyfile);
> > return NULL;
>
>
> Now filename list is decoupled from keys themselves. Also we have key
> list creation in init_public_keys(). Maybe we should just always call
> init_public_keys for verify operations?
With v2 of "ima_evm_utils: erroneous "verification failed: 0 (invalid
padding)" message", I was able to drop this patch.
Mimi
next prev parent reply other threads:[~2019-07-17 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 14:30 [PATCH 1/2] ima_evm_utils: erroneous "verification failed: 0 (invalid padding)" message Mimi Zohar
2019-07-16 14:30 ` [PATCH 2/2] ima_evm_utils: limit duplicate "Failed to open keyfile" messages Mimi Zohar
2019-07-16 21:49 ` Vitaly Chikunov
2019-07-16 22:13 ` Mimi Zohar
2019-07-17 13:23 ` Mimi Zohar [this message]
2019-07-16 21:37 ` [PATCH 1/2] ima_evm_utils: erroneous "verification failed: 0 (invalid padding)" message Vitaly Chikunov
2019-07-16 21:55 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563369814.4539.290.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).