From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48326C76186 for ; Tue, 23 Jul 2019 19:38:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23BE6218F0 for ; Tue, 23 Jul 2019 19:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391730AbfGWTie (ORCPT ); Tue, 23 Jul 2019 15:38:34 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59288 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730048AbfGWTie (ORCPT ); Tue, 23 Jul 2019 15:38:34 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6NJcSF9051944 for ; Tue, 23 Jul 2019 15:38:33 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2tx85yry0v-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 23 Jul 2019 15:38:31 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Jul 2019 20:37:44 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 23 Jul 2019 20:37:41 +0100 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6NJbeHh45875392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jul 2019 19:37:40 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 77B09A405B; Tue, 23 Jul 2019 19:37:40 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AA39EA405F; Tue, 23 Jul 2019 19:37:39 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.82.157]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 23 Jul 2019 19:37:39 +0000 (GMT) Subject: Re: [PATCH v2] ima-evm-utils: use tsspcrread to read the TPM 2.0 PCRs From: Mimi Zohar To: Vitaly Chikunov Cc: "Bruno E. O. Meneguele" , linux-integrity@vger.kernel.org, Petr Vorel , Dmitry Eremin-Solenikov Date: Tue, 23 Jul 2019 15:37:28 -0400 In-Reply-To: <20190723193114.vqwuiu6lcxdjyvhv@altlinux.org> References: <1563893743-4586-1-git-send-email-zohar@linux.ibm.com> <20190723154759.GB16649@glitch> <1563897190.14396.144.camel@linux.ibm.com> <20190723164144.ewrcvrod7m6rahkg@altlinux.org> <1563906293.14396.163.camel@linux.ibm.com> <20190723193114.vqwuiu6lcxdjyvhv@altlinux.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19072319-0016-0000-0000-000002957E27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19072319-0017-0000-0000-000032F37001 Message-Id: <1563910648.4294.2.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-23_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=911 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907230200 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, 2019-07-23 at 22:31 +0300, Vitaly Chikunov wrote: > Mimi, > > On Tue, Jul 23, 2019 at 02:24:53PM -0400, Mimi Zohar wrote: > > On Tue, 2019-07-23 at 19:41 +0300, Vitaly Chikunov wrote: > > > On Tue, Jul 23, 2019 at 11:53:10AM -0400, Mimi Zohar wrote: > > > > On Tue, 2019-07-23 at 12:47 -0300, Bruno E. O. Meneguele wrote: > > > > > > > > > > @@ -1402,6 +1400,41 @@ static int tpm_pcr_read(int idx, uint8_t *pcr, int len) > > > > > > return result; > > > > > > } > > > > > > > > > > > > +#ifdef HAVE_TSSPCRREAD > > > > > > +static int tpm2_pcr_read(int idx, uint8_t *hwpcr, int len, char **errmsg) > > > > > > +{ > > > > > > + FILE *fp; > > > > > > + char pcr[100]; /* may contain an error */ > > > > > > + char cmd[50]; > > > > > > + int ret; > > > > > > + > > > > > > + sprintf(cmd, "tsspcrread -halg sha1 -ha %d -ns 2> /dev/null", idx); > > > > > > + fp = popen(cmd, "r"); > > > > > > + if (!fp) { > > > > > > + snprintf(pcr, sizeof(pcr), "popen failed: %s", strerror(errno)); > > > > > > + *errmsg = strdup("popen failed:"); > > > > > > > > > > Should it have been > > > > > > > > > > *errmsg = strdup(pcr); > > > > > > > > > Yes, of course. > > > > > > Or better to use asprintf(3). > > > > That's even better, assuming that we want to include > > AC_USE_SYSTEM_EXTENSIONS in configure.ac? > > Yes. > > > Did you want to make this change as a separate patch, or should I fold > > it into this one? > > Probably you, since you are first to add snprintf+strdup. I didn't mean instead of this patch, but in addition to, on top of this patch with the "strdup(pcr)" correction. Mimi