From: Mimi Zohar <zohar@linux.ibm.com>
To: "Bruno E. O. Meneguele" <bmeneg@redhat.com>,
Petr Vorel <pvorel@suse.cz>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-integrity <linux-integrity@vger.kernel.org>
Subject: Re: ima-evm-utils: library version
Date: Wed, 24 Jul 2019 20:36:36 -0400 [thread overview]
Message-ID: <1564014996.4245.79.camel@linux.ibm.com> (raw)
In-Reply-To: <20190724180440.GD3726@rhlt>
On Wed, 2019-07-24 at 15:04 -0300, Bruno E. O. Meneguele wrote:
> On Wed, Jul 24, 2019 at 08:28:01PM +0300, Vitaly Chikunov wrote:
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index 9c037e2..b794c50 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
> > @@ -4,7 +4,7 @@ libimaevm_la_SOURCES = libimaevm.c
> > libimaevm_la_CPPFLAGS = $(AM_CPPFLAGS) $(LIBCRYPTO_CFLAGS)
> > # current[:revision[:age]]
> > # result: [current-age].age.revision
> > -libimaevm_la_LDFLAGS = -version-info 0:0:0
> > +libimaevm_la_LDFLAGS = -version-info 1:0:0
> > libimaevm_la_LIBADD = $(LIBCRYPTO_LIBS)
> >
> > Thanks,
>
> And I also agree with his patch, changing -version-info to 1:0:0,
> bumping "current" number, since the interface was indeed changed since
> v1.1 release of ima-evm-utils.
>
> Thanks for catching that :))
Thanks! We'll use the libtool versioning.
Mimi
next prev parent reply other threads:[~2019-07-25 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 12:51 ima-evm-utils: library version Mimi Zohar
2019-07-24 17:28 ` Vitaly Chikunov
2019-07-24 18:04 ` Bruno E. O. Meneguele
2019-07-25 0:36 ` Mimi Zohar [this message]
2019-07-24 19:17 ` Vitaly Chikunov
2019-07-24 22:27 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564014996.4245.79.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=bmeneg@redhat.com \
--cc=dbaryshkov@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).