From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E98C7618B for ; Thu, 25 Jul 2019 14:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28C8E21901 for ; Thu, 25 Jul 2019 14:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728458AbfGYO3T (ORCPT ); Thu, 25 Jul 2019 10:29:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48112 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725867AbfGYO3T (ORCPT ); Thu, 25 Jul 2019 10:29:19 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6PEK6jw116808 for ; Thu, 25 Jul 2019 10:29:17 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2tyd1ebhwb-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Jul 2019 10:29:17 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Jul 2019 15:29:16 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 25 Jul 2019 15:29:14 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6PETDbF48234720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jul 2019 14:29:13 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 89B524C052; Thu, 25 Jul 2019 14:29:13 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D8CEE4C050; Thu, 25 Jul 2019 14:29:12 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.82.197]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 25 Jul 2019 14:29:12 +0000 (GMT) Subject: Re: [PATCH 1/2] ima-evm-utils: Do not allow fallback and unknown hash algos From: Mimi Zohar To: Vitaly Chikunov Cc: Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org Date: Thu, 25 Jul 2019 10:29:02 -0400 In-Reply-To: <20190725140832.lyfchzy2i6s5njnk@altlinux.org> References: <20190725061306.30515-1-vt@altlinux.org> <1564062242.4245.113.camel@linux.ibm.com> <20190725140832.lyfchzy2i6s5njnk@altlinux.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19072514-0020-0000-0000-0000035727EA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19072514-0021-0000-0000-000021AB1CD8 Message-Id: <1564064942.4245.118.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-25_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=820 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907250167 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 2019-07-25 at 17:08 +0300, Vitaly Chikunov wrote: > Mimi, > > On Thu, Jul 25, 2019 at 09:44:02AM -0400, Mimi Zohar wrote: > > On Thu, 2019-07-25 at 09:13 +0300, Vitaly Chikunov wrote: > > > Falling back and permissiveness could have security implications. > > > > > > Signed-off-by: Vitaly Chikunov > > > > Thanks!  Please update the README, removing "(default)", and rebase on > > top of the "param" changes. > > In my understanding this text in README should not be changed, since not > specifying `-a' is the same as `-a sha1', so default holds. Code > handling this is not changed (which is in src/libimaevm.c:87). Agreed > > What I changed is some other unexpected switching to sha1. Like when > user specify wrong hash name in `-a'. > > So I will not resend this (as there is no changes). And I want to rebase > `param' & `imaevm_' prefix patch over these two commits. That works. thanks, Mimi