Re: [PATCH v4] ima-evm-utils: Add some tests for evmctl

[Mimi Zohar <zohar@linux.ibm.com>]

Hi Vitaly,

On Wed, 2019-07-31 at 08:26 +0300, Vitaly Chikunov wrote:
> Run `make check' to execute the tests.
> Currently only ima_hash, (evm) sign, (evm) verify, ima_sign, and
> ima_verify are tested.
> 
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>

I probably haven't applied all of the prereq patches, so some of the
tests are failing.  As a result, I found:

- (Thank you for changing the simple "FOR" variable.)  There are a
couple of "ADD_FOR_TEXT" instead of "ADD_TEXT_FOR".

> +
> +# Test if xattr $attr in $file matches $pref'ix
> +# Show error and fail otherwise.
> +_test_xattr() {
> +  local file=$1 attr=$2 pref=$3
> +  local test_for=${ADD_TEXT_FOR:+ for $ADD_TEXT_FOR}
> +
> +  if ! getfattr -n $attr -e hex $file | egrep -qx "$attr=$pref"; then
> +    red_if_failure
> +    echo "Did not find expected hash$text_for:"

^test_for

> +    echo "    $attr=$pref"
> +    echo ""
> +    echo "Actual output below:"
> +    getfattr -n $attr -e hex $file | sed 's/^/    /'
> +    color_restore
> +    rm $file
> +    ADD_TEXT_FOR=
> +    return $FAIL
> +  fi
> +  ADD_TEXT_FOR=
> +}

Mimi