From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40CB7C4CEC7 for ; Mon, 16 Sep 2019 03:27:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A300214AF for ; Mon, 16 Sep 2019 03:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727285AbfIPD16 (ORCPT ); Sun, 15 Sep 2019 23:27:58 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47554 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726222AbfIPD16 (ORCPT ); Sun, 15 Sep 2019 23:27:58 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8G3MWM1030397 for ; Sun, 15 Sep 2019 23:27:57 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2v1xa74vb6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 15 Sep 2019 23:27:56 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Sep 2019 04:27:55 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 16 Sep 2019 04:27:53 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8G3Rq7v17432710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Sep 2019 03:27:52 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 67E9F52059; Mon, 16 Sep 2019 03:27:52 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.200.126]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id C14C25204E; Mon, 16 Sep 2019 03:27:51 +0000 (GMT) Subject: Re: [PATCH] selftest/trustedkeys: TPM 1.2 trusted keys test From: Mimi Zohar To: Jarkko Sakkinen Cc: linux-integrity@vger.kernel.org, Roberto Sassu , Petr Vorel Date: Sun, 15 Sep 2019 23:27:51 -0400 In-Reply-To: <1568580742.5055.0.camel@linux.ibm.com> References: <1568157511-5464-1-git-send-email-zohar@linux.ibm.com> <1568157876.4991.3.camel@linux.ibm.com> <1568203240.5783.8.camel@linux.ibm.com> <20190913140820.GC29755@linux.intel.com> <1568580742.5055.0.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19091603-0028-0000-0000-0000039D504C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19091603-0029-0000-0000-0000245FC36D Message-Id: <1568604471.4975.8.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-16_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909160034 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Sun, 2019-09-15 at 16:52 -0400, Mimi Zohar wrote: > On Fri, 2019-09-13 at 15:08 +0100, Jarkko Sakkinen wrote: > > On Wed, Sep 11, 2019 at 08:00:40AM -0400, Mimi Zohar wrote: > > > On Tue, 2019-09-10 at 19:24 -0400, Mimi Zohar wrote: > > > > On Tue, 2019-09-10 at 19:18 -0400, Mimi Zohar wrote: > > > > > Create, save and load trusted keys test > > > > > > > > Creating trusted keys is failing with the following messages. Any idea why? > > > > > > > > [ 147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command > > > > [ 147.014678] trusted_key: srkseal failed (-1) > > > > [ 147.014687] trusted_key: key_seal failed (-1) > > > > > > This is a regression, that needs to be resolved.  The test works on > > > kernels prior to 5.1. > > > > It breaks on 5.2? > > No, the regression is in 5.1. > > > > > Can you bisect the failing commit? > > git bisect start -- drivers/char/tpm/ > git bisect bad > git bisect good v5.0  > > # first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm: > use tpm_buf in tpm_transmit_cmd() as the IO parameter In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem. Mimi