From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org
Subject: Re: [integrity:next-integrity-testing 5/5] security/integrity/ima/ima_asymmetric_keys.c:53:6: error: redefinition of 'ima_init_key_queue'
Date: Mon, 06 Jan 2020 06:58:00 -0800 [thread overview]
Message-ID: <1578322680.3455.6.camel@HansenPartnership.com> (raw)
In-Reply-To: <dd99db8f-08de-d7ac-3d63-0717fc6c7ba5@linux.microsoft.com>
On Sun, 2020-01-05 at 19:58 -0800, Lakshmi Ramasubramanian wrote:
> On 1/5/20 11:16 AM, James Bottomley wrote:
>
> > Well, yes, you just need to condition the build of
> > ima_asymmetric_keys
> > on a boolean instead of a tristate, so you introduce an
> > intermediate
> > one:
> >
> > config IMA_ASYMMETRIC_KEYS
> > bool
> > default y
> > depends on ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y
> >
> > James
>
> Thanks for your help James.
>
> Hi Mimi,
>
> I have defined a new config as James has suggested above and
> verified the kernel builds fine with the ".config" files given by
> "kbuild test robot <lkp@intel.com>".
>
> Would it be possible to share all the ".config" files that
> "kbuild test robot" would build with? I'll make sure my changes
> build fine with all those.
I'm afraid it's not possible: the kbuild robot is doing make
randconfig, which generates a random configuration for the kernel. The
randconfig testing is the easiest way to detect Kconfig problems like
this one. You can, of course, do make randconfig yourself, but you
have to run through it a lot of times to get the coverage the robot
gets.
James
prev parent reply other threads:[~2020-01-06 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 9:00 [integrity:next-integrity-testing 5/5] security/integrity/ima/ima_asymmetric_keys.c:53:6: error: redefinition of 'ima_init_key_queue' kbuild test robot
2020-01-05 17:57 ` Lakshmi Ramasubramanian
2020-01-05 18:15 ` James Bottomley
2020-01-05 18:56 ` Lakshmi Ramasubramanian
2020-01-05 19:16 ` James Bottomley
2020-01-06 3:58 ` Lakshmi Ramasubramanian
2020-01-06 13:23 ` Mimi Zohar
2020-01-06 14:58 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1578322680.3455.6.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-integrity@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox