From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB7CC18E5A for ; Mon, 9 Mar 2020 13:59:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE23520848 for ; Mon, 9 Mar 2020 13:59:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="FvMsHvn6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="FvMsHvn6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726784AbgCIN7s (ORCPT ); Mon, 9 Mar 2020 09:59:48 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:48754 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbgCIN7s (ORCPT ); Mon, 9 Mar 2020 09:59:48 -0400 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id B954A8EE130; Mon, 9 Mar 2020 06:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1583762387; bh=Qtz6cbmzCipAwmDMT8lTR4BIxtTJWStyW/r+A4vHAvM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=FvMsHvn66QHZcXvlAEAkY4L3hhTXpALvk0rPiW234CRGs5pWyxjRqvYYljjdF6b9u 0EmJ+QAqki02VRrzSL0qvWJu4u4j4QuoD8ZkA6mPxjOpZsPehGP9G+AeQ4Oj9jI/7h 3QyyyTz9s+fHZ4Ax6PTEOusrLJu2m3Bbt7PAsWao= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n218m5WzUryQ; Mon, 9 Mar 2020 06:59:47 -0700 (PDT) Received: from [153.66.254.194] (unknown [50.35.76.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 5B8418EE121; Mon, 9 Mar 2020 06:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1583762387; bh=Qtz6cbmzCipAwmDMT8lTR4BIxtTJWStyW/r+A4vHAvM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=FvMsHvn66QHZcXvlAEAkY4L3hhTXpALvk0rPiW234CRGs5pWyxjRqvYYljjdF6b9u 0EmJ+QAqki02VRrzSL0qvWJu4u4j4QuoD8ZkA6mPxjOpZsPehGP9G+AeQ4Oj9jI/7h 3QyyyTz9s+fHZ4Ax6PTEOusrLJu2m3Bbt7PAsWao= Message-ID: <1583762386.3429.6.camel@HansenPartnership.com> Subject: Re: [PATCH v7 4/6] security: keys: trusted: use ASN.1 TPM2 key format for the blobs From: James Bottomley To: Jarkko Sakkinen Cc: linux-integrity@vger.kernel.org, Mimi Zohar , David Woodhouse , keyrings@vger.kernel.org Date: Mon, 09 Mar 2020 06:59:46 -0700 In-Reply-To: <20200307220026.GA122868@linux.intel.com> References: <20200305022744.12492-1-James.Bottomley@HansenPartnership.com> <20200305022744.12492-5-James.Bottomley@HansenPartnership.com> <20200307220026.GA122868@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Sun, 2020-03-08 at 00:00 +0200, Jarkko Sakkinen wrote: > On Wed, Mar 04, 2020 at 06:27:42PM -0800, James Bottomley wrote: > > Modify the TPM2 key format blob output to export and import in the > > ASN.1 form for TPM2 sealed object keys. For compatibility with > > prior > > trusted keys, the importer will also accept two TPM2B quantities > > representing the public and private parts of the key. However, the > > export via keyctl pipe will only output the ASN.1 format. > > > > The benefit of the ASN.1 format is that it's a standard and thus > > the > > exported key can be used by userspace tools (openssl_tpm2_engine, > > openconnect and tpm2-tss-engine). The format includes policy > > specifications, thus it gets us out of having to construct policy > > handles in userspace and the format includes the parent meaning you > > don't have to keep passing it in each time. > > > > This patch only implements basic handling for the ASN.1 format, so > > keys with passwords but no policy. > > > > Signed-off-by: James Bottomley > om> > > Not yet sure but I get > > keyctl add trusted kmk "new 32 keyhandle=0x81000001 hash=sha1 > pcrinfo=03000001 6768033e216468247bd031a0a2d9876d79818f8f" @u > add_key: No such device What's the last hex string? Is there supposed to be a command preceding it (like blobauth since there's 40 hex chars?). > After applying 1/6-4/6. As you guessed for most of the rebases I've been testing the whole set of patches. Let me wind back to 4/6 and have a look. > At this point I'm assuming that I've made mistake somewhere, which is > entirely possible. Heh, don't bet on it, I should be able to reconstruct the environment today and try it out. James