linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>,
	linux-kernel@vger.kernel.org
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] drivers: char: tpm: remove unneeded MODULE_VERSION() usage
Date: Tue, 17 Dec 2019 13:16:11 +0200	[thread overview]
Message-ID: <1a68db2aee382a1b0472cf0b81a809bc089e622d.camel@linux.intel.com> (raw)
In-Reply-To: <20191216084230.31412-1-info@metux.net>

On Mon, 2019-12-16 at 09:42 +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.

Take the following line away:

> See also: https://lkml.org/lkml/2017/11/22/480

And just before SOB:

Link: https://lkml.org/lkml/2017/11/22/480
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

You have some extra cruft there. It should be:

Signed-off-by: Enrico Weigelt <info@metux.net>

/Jarkko


  reply	other threads:[~2019-12-17 11:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  8:42 [PATCH] drivers: char: tpm: remove unneeded MODULE_VERSION() usage Enrico Weigelt, metux IT consult
2019-12-17 11:16 ` Jarkko Sakkinen [this message]
2019-12-17 11:17   ` Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2020-12-02 12:15 Enrico Weigelt, metux IT consult
2020-12-02 17:06 ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a68db2aee382a1b0472cf0b81a809bc089e622d.camel@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=info@metux.net \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).