linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc: Petr Vorel <pvorel@suse.cz>, Vitaly Chikunov <vt@altlinux.org>
Subject: Re: [PATCH ima-evm-utils v4 14/17] Base sm2/sm3 test on openssl version installed
Date: Tue, 1 Nov 2022 17:25:29 -0400	[thread overview]
Message-ID: <1dc2c60f-b573-7b8a-ad5c-70567249bf4e@linux.ibm.com> (raw)
In-Reply-To: <20221101201803.372652-15-zohar@linux.ibm.com>



On 11/1/22 16:18, Mimi Zohar wrote:
> Since the distros are now shipping with OpenSSL 3, no need
> to build it.  Limit the sm2/sm3 test to OpenSSL 3.
> 
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
>   tests/sign_verify.test | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/sign_verify.test b/tests/sign_verify.test
> index 3e9548e1aeb7..ed95f6955dc1 100755
> --- a/tests/sign_verify.test
> +++ b/tests/sign_verify.test
> @@ -416,8 +416,8 @@ sign_verify  prime256v1 sha384 0x030205:K:004[345678]
>   sign_verify  prime256v1 sha512 0x030206:K:004[345678]
>   
>   # If openssl 3.0 is installed, test the SM2/3 algorithm combination
> -if [ -x /opt/openssl3/bin/openssl ]; then
> -  PATH=/opt/openssl3/bin:$PATH LD_LIBRARY_PATH=/opt/openssl3/lib \
> +ssl_version=$(openssl version | sed -e 's/^OpenSSL //' | sed -e 's/ .*//')

This would give you the major number in one step by selecting all all characters after 'OpenSSL ' and before the first '.':

major=$(openssl version | sed -n 's/^OpenSSL \([^\.]\).*/\1/p')


> +if test "${ssl_version::1}" = "3"; then
>       sign_verify  sm2    sm3    0x030211:K:004[345678]
>   fi
>   

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>


  reply	other threads:[~2022-11-01 21:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01 20:17 [PATCH ima-evm-utils v4 00/17] address deprecated warnings Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 01/17] Revert "Reset 'errno' after failure to open or access a file" Mimi Zohar
2022-11-01 21:46   ` Stefan Berger
2022-11-01 23:04     ` Mimi Zohar
2022-11-02  0:25       ` Stefan Berger
2022-11-03 13:54         ` Mimi Zohar
2022-11-03 14:32           ` Petr Vorel
2022-11-03 21:35             ` Mimi Zohar
2022-11-03 22:50               ` Vitaly Chikunov
2022-11-13 21:25                 ` Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 02/17] log and reset 'errno' after failure to open non-critical files Mimi Zohar
2022-11-02 21:02   ` Stefan Berger
2022-11-03  3:13     ` Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 03/17] Log and reset 'errno' on lsetxattr failure Mimi Zohar
2022-11-02 15:55   ` Stefan Berger
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 04/17] travis: update dist=focal Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 05/17] Update configure.ac to address a couple of obsolete warnings Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 06/17] Deprecate IMA signature version 1 Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 07/17] Replace the low level SHA1 calls when calculating the TPM 1.2 PCRs Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 08/17] Replace the low level HMAC calls when calculating the EVM HMAC Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 09/17] Add missing EVP_MD_CTX_free() call in calc_evm_hash() Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 10/17] Disable use of OpenSSL "engine" support Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 11/17] Fix potential use after free in read_tpm_banks() Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 12/17] Limit the file hash algorithm name length Mimi Zohar
2022-11-01 20:17 ` [PATCH ima-evm-utils v4 13/17] Missing template data size lower bounds checking Mimi Zohar
2022-11-01 20:18 ` [PATCH ima-evm-utils v4 14/17] Base sm2/sm3 test on openssl version installed Mimi Zohar
2022-11-01 21:25   ` Stefan Berger [this message]
2022-11-01 20:18 ` [PATCH ima-evm-utils v4 15/17] Compile a newer version of OpenSSL Mimi Zohar
2022-11-01 20:18 ` [PATCH ima-evm-utils v4 16/17] Build OpenSSL without engine support Mimi Zohar
2022-11-01 20:18 ` [PATCH ima-evm-utils v4 17/17] Fix d2i_x509_fp failure Mimi Zohar
2022-11-02  0:44   ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dc2c60f-b573-7b8a-ad5c-70567249bf4e@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=pvorel@suse.cz \
    --cc=vt@altlinux.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).