From: Nayna Jain <nayna@linux.vnet.ibm.com>
To: linux-integrity@vger.kernel.org
Cc: zohar@linux.vnet.ibm.com, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, peterhuewe@gmx.de,
jarkko.sakkinen@linux.intel.com, tpmdd@selhorst.net,
jgunthorpe@obsidianresearch.com, patrickc@us.ibm.com,
Nayna Jain <nayna@linux.vnet.ibm.com>
Subject: [PATCH v3 0/4] additional TPM performance improvements
Date: Wed, 4 Oct 2017 06:29:19 -0400 [thread overview]
Message-ID: <20171004102924.12355-1-nayna@linux.vnet.ibm.com> (raw)
After further discussions with the TCG Device Driver working group (ddwg),
the following changes were made:
* Check for burstcount at least once to confirm the TPM is ready to accept
the data. Similarly, query for the TPM Expect status as sanity check at
the end.
* Make the sleep for status check in the loop less than 5msec.
* Make the sleep in the loop while querying for burstcount less than
5msec.
Below is the list of patches along with the performance improvements
seen with a TPM 1.2 with an 8 byte burstcount for 1000 extends:
Patch |Improvement(time in sec)
tpm: ignore burstcount to improve tpm_tis | ~41 - ~14
send() performance.
tpm: reduce polling delay in tpm_tis | ~14 - ~10
wait_for_tpm_stat()
tpm: reduce tpm_msleep() time in | ~10 - ~9
get_burstcount()
tpm: modify tpm_msleep() function to have | ~9 - ~8
max range
Changelog v3:
* Include Jarkko's feedback to move wait_for_tpm_stat() from
tpm-interface.c to respective driver files tpm_tis_core.c and
xen-tpmfront.c.
* Remove use of module parameter ignore_burst_count and is
now alwaysed ignored in tpm tis send() operation.
* Reduce sleep() time during polling in wait_for_tpm_stat() from
5msec to 1msec for both recv() and send() operation. Version
2 of the patches had it only for send() operation.
Changelog v2:
* Add module parameter to handle ignoring of burst count during
tpm tis send() operation.
* Add improvements over sleep time to reduce delays.
Nayna Jain (5):
tpm: move wait_for_tpm_stat() to respective driver files
tpm: ignore burstcount to improve tpm_tis send() performance
tpm: reduce polling delay in tpm_tis wait_for_tpm_stat()
tpm: reduce tpm_msleep() time in get_burstcount()
tpm: use tpm_msleep() value as max delay
drivers/char/tpm/tpm-interface.c | 60 ----------------------
drivers/char/tpm/tpm.h | 6 +--
drivers/char/tpm/tpm_tis_core.c | 106 +++++++++++++++++++++++++++++----------
drivers/char/tpm/xen-tpmfront.c | 60 ++++++++++++++++++++++
4 files changed, 141 insertions(+), 91 deletions(-)
--
2.13.3
next reply other threads:[~2017-10-04 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 10:29 Nayna Jain [this message]
2017-10-04 10:29 ` [PATCH v3 1/5] tpm: move wait_for_tpm_stat() to respective driver files Nayna Jain
2017-10-10 14:57 ` Jarkko Sakkinen
2017-10-04 10:29 ` [PATCH v3 2/5] tpm: ignore burstcount to improve tpm_tis send() performance Nayna Jain
2017-10-10 15:04 ` Jarkko Sakkinen
2017-10-11 11:29 ` Nayna Jain
2017-10-04 10:29 ` [PATCH v3 3/5] tpm: reduce polling delay in tpm_tis wait_for_tpm_stat() Nayna Jain
2017-10-12 11:17 ` Jarkko Sakkinen
2017-10-04 10:29 ` [PATCH v3 4/5] tpm: reduce tpm_msleep() time in get_burstcount() Nayna Jain
2017-10-12 11:18 ` Jarkko Sakkinen
2017-10-12 13:14 ` Nayna Jain
2017-10-04 10:29 ` [PATCH v3 5/5] tpm: use tpm_msleep() value as max delay Nayna Jain
2017-10-12 11:19 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004102924.12355-1-nayna@linux.vnet.ibm.com \
--to=nayna@linux.vnet.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=patrickc@us.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd@selhorst.net \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).