linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nayna Jain <nayna@linux.vnet.ibm.com>
To: linux-integrity@vger.kernel.org
Cc: zohar@linux.vnet.ibm.com, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, peterhuewe@gmx.de,
	jarkko.sakkinen@linux.intel.com, tpmdd@selhorst.net,
	jgunthorpe@obsidianresearch.com, patrickc@us.ibm.com,
	Nayna Jain <nayna@linux.vnet.ibm.com>
Subject: [PATCH v4 4/4] tpm: use tpm_msleep() value as max delay
Date: Tue, 17 Oct 2017 16:32:32 -0400	[thread overview]
Message-ID: <20171017203232.2262-5-nayna@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171017203232.2262-1-nayna@linux.vnet.ibm.com>

Currently, tpm_msleep() uses delay_msec as the minimum value in
usleep_range. However, that is the maximum time we want to wait.
The function is modified to use the delay_msec as the maximum
value, not the minimum value.

After this change, performance on a TPM 1.2 with an 8 byte
burstcount for 1000 extends improved from ~9sec to ~8sec.

Fixes: 3b9af007869("tpm: replace msleep() with usleep_range() in TPM 1.2/
2.0 generic drivers")

Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 drivers/char/tpm/tpm.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 4fc83ac7abeb..644de70de2cc 100644
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -528,8 +528,8 @@ int tpm_pm_resume(struct device *dev);
 
 static inline void tpm_msleep(unsigned int delay_msec)
 {
-	usleep_range(delay_msec * 1000,
-		     (delay_msec * 1000) + TPM_TIMEOUT_RANGE_US);
+	usleep_range((delay_msec * 1000) - TPM_TIMEOUT_RANGE_US,
+		     delay_msec * 1000);
 };
 
 struct tpm_chip *tpm_chip_find_get(int chip_num);
-- 
2.13.3

  parent reply	other threads:[~2017-10-17 20:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 20:32 [PATCH v4 0/4] additional TPM performance improvements Nayna Jain
2017-10-17 20:32 ` [PATCH v4 1/4] tpm: move wait_for_tpm_stat() to respective driver files Nayna Jain
2017-10-19 14:21   ` Jarkko Sakkinen
2017-10-19 17:00     ` Alexander.Steffen
2017-10-20  8:56       ` Jarkko Sakkinen
2017-10-23 13:32         ` Nayna Jain
2017-10-24 13:45           ` Jarkko Sakkinen
2017-10-17 20:32 ` [PATCH v4 2/4] tpm: ignore burstcount to improve tpm_tis send() performance Nayna Jain
2017-10-18 15:25   ` Jarkko Sakkinen
2017-10-19 14:23   ` Jarkko Sakkinen
2017-10-20 14:42   ` Alexander.Steffen
2017-10-20 18:02     ` Ken Goldman
2017-10-23  2:57     ` Jarkko Sakkinen
2017-11-07 18:29     ` Nayna Jain
2017-11-08 11:32       ` Alexander.Steffen
2017-11-16 14:34       ` Alexander.Steffen
2017-11-22  6:52       ` Alexander.Steffen
2017-11-23 14:47         ` Nayna Jain
2017-11-23 16:19           ` Alexander.Steffen
2017-11-26 15:22           ` Jarkko Sakkinen
2017-11-26 16:37             ` Mimi Zohar
2017-11-27  7:08               ` Leendert van Doorn
2017-11-27 13:22                 ` Mimi Zohar
2017-11-28 20:19                 ` Jarkko Sakkinen
2017-10-17 20:32 ` [PATCH v4 3/4] tpm: reduce tpm polling delay in tpm_tis_core Nayna Jain
2017-10-18 15:24   ` Jarkko Sakkinen
2017-10-19 14:22     ` Jarkko Sakkinen
2017-10-17 20:32 ` Nayna Jain [this message]
2017-10-19 14:22   ` [PATCH v4 4/4] tpm: use tpm_msleep() value as max delay Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017203232.2262-5-nayna@linux.vnet.ibm.com \
    --to=nayna@linux.vnet.ibm.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=patrickc@us.ibm.com \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd@selhorst.net \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).