From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Shaikh, Azhar" <azhar.shaikh@intel.com>
Cc: "jarkko.sakkinen@linux.intel.com"
<jarkko.sakkinen@linux.intel.com>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>
Subject: Re: [PATCH RFC v3 1/2] tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()
Date: Mon, 20 Nov 2017 16:26:04 -0700 [thread overview]
Message-ID: <20171120232604.GS29075@ziepe.ca> (raw)
In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF582896EA2E@ORSMSX109.amr.corp.intel.com>
On Mon, Nov 20, 2017 at 09:19:37PM +0000, Shaikh, Azhar wrote:
> -> tpm_tis_core_init()
Yes, and IIRC, this covers tpm_tis_update_timeouts() too?
> -> tpm_tis_plat_remove()
This should be in tpm_tis_remove and a little rework would be needed
here
> -> tpm_tis_reenable_interrupts()
> -> tpm_transmit_cmd() [ Already implemented in this patch ]
Yes
> >You could add a debug to ensure that read/write is never without clk_enable
> >being held.
>
> Sorry, but I didn't get this, adding a debug part.
Just check a flag in the read/write functions to see if clkrun is on
and WARN if not
Not sure if this is going to be overall better than what you have or
not.. But considering the nature of the bug it seems safer to have a
wider range when CLKRUN is working?
Jason
next prev parent reply other threads:[~2017-11-20 23:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 22:07 [PATCH RFC v3 0/2] Fix corner cases with disabling CLKRUN in tpm_tis Azhar Shaikh
2017-11-15 22:07 ` [PATCH RFC v3 1/2] tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd() Azhar Shaikh
2017-11-20 18:34 ` Jason Gunthorpe
2017-11-20 18:52 ` Shaikh, Azhar
2017-11-20 19:21 ` Jason Gunthorpe
2017-11-20 19:34 ` Shaikh, Azhar
2017-11-20 19:38 ` Jason Gunthorpe
2017-11-20 21:19 ` Shaikh, Azhar
2017-11-20 23:26 ` Jason Gunthorpe [this message]
2017-11-21 19:18 ` Shaikh, Azhar
2017-11-21 19:27 ` Jason Gunthorpe
2017-11-20 23:19 ` Jarkko Sakkinen
2017-11-20 23:17 ` Jarkko Sakkinen
2017-11-15 22:07 ` [PATCH RFC v3 2/2] tpm_tis: Move ilb_base_addr to tpm_tis_tcg_phy Azhar Shaikh
2017-11-20 23:18 ` Jarkko Sakkinen
2017-11-20 15:58 ` [PATCH RFC v3 0/2] Fix corner cases with disabling CLKRUN in tpm_tis Shaikh, Azhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120232604.GS29075@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=azhar.shaikh@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).