From: Jason Gunthorpe <jgg@ziepe.ca>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: "Shaikh, Azhar" <azhar.shaikh@intel.com>,
"Alexander.Steffen@infineon.com" <Alexander.Steffen@infineon.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"james@ettle.org.uk" <james@ettle.org.uk>,
"arnd@arndb.de" <arnd@arndb.de>,
"jarkko.sakkinen@linux.intel.com"
<jarkko.sakkinen@linux.intel.com>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>
Subject: Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled
Date: Wed, 20 Dec 2017 10:44:00 -0700 [thread overview]
Message-ID: <20171220174400.GA22908@ziepe.ca> (raw)
In-Reply-To: <ba99c3c1-c3da-4045-a9d9-3801793db6b1@redhat.com>
On Wed, Dec 20, 2017 at 05:45:16PM +0100, Javier Martinez Canillas wrote:
> CHP51 says "LPC Clock Control Using the LPC_CLKRUN# May Not Behave As Expected"
> and that the implication is that "The SoC may prevent a peripheral device from
> successfully requesting the LPC clock".
Now we are back to the beginning - the LPC_CLKRUN protocol is simply
broken in BSW chipsets, and it has nothing to do with the TPM?
Intel is trying to work around that broken-ness and still preserve
power management in the case where only the TPM is connected to the
LPC bus.. It is questionable to me if this is even a good idea, or if
Linux is the right place to implement this work around (eg something
in SMM mode may be more appropriate for a chipset bug)
I think your patch is still the right improvement, if the BIOS turned
the feature off, we should not turn it back on.
Jason
next prev parent reply other threads:[~2017-12-20 17:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 11:35 [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Javier Martinez Canillas
2017-12-20 11:35 ` [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region Javier Martinez Canillas
2017-12-20 15:25 ` Shaikh, Azhar
2017-12-20 18:08 ` Jason Gunthorpe
2017-12-20 18:21 ` Javier Martinez Canillas
2017-12-20 18:54 ` Jason Gunthorpe
2017-12-20 19:15 ` Shaikh, Azhar
2017-12-21 12:48 ` Javier Martinez Canillas
2017-12-21 15:39 ` Shaikh, Azhar
2017-12-21 15:53 ` Javier Martinez Canillas
2017-12-21 16:34 ` Shaikh, Azhar
2017-12-22 18:35 ` Jarkko Sakkinen
2017-12-24 20:57 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag Javier Martinez Canillas
2017-12-20 15:19 ` Shaikh, Azhar
2017-12-20 18:10 ` Jason Gunthorpe
2017-12-20 18:26 ` Javier Martinez Canillas
2017-12-22 18:38 ` Jarkko Sakkinen
2017-12-22 18:33 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 3/4] tpm: follow coding style for variable declaration in tpm_tis_core_init() Javier Martinez Canillas
2017-12-22 18:32 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 4/4] tpm: only attempt to disable the LPC CLKRUN if is already enabled Javier Martinez Canillas
2017-12-22 18:36 ` Jarkko Sakkinen
2017-12-20 11:43 ` [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Hans de Goede
2017-12-20 12:12 ` Javier Martinez Canillas
2017-12-20 14:07 ` Alexander.Steffen
2017-12-20 14:35 ` Javier Martinez Canillas
2017-12-20 15:08 ` Shaikh, Azhar
2017-12-20 15:31 ` Javier Martinez Canillas
2017-12-20 15:41 ` Shaikh, Azhar
2017-12-20 16:45 ` Javier Martinez Canillas
2017-12-20 17:44 ` Jason Gunthorpe [this message]
2017-12-20 18:33 ` Javier Martinez Canillas
2017-12-22 18:39 ` Jarkko Sakkinen
2017-12-21 10:51 ` James Ettle
2017-12-21 12:46 ` Javier Martinez Canillas
2017-12-21 17:25 ` Jeffery Miller
2017-12-21 18:44 ` Javier Martinez Canillas
2017-12-21 19:02 ` Jeffery Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220174400.GA22908@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Alexander.Steffen@infineon.com \
--cc=arnd@arndb.de \
--cc=azhar.shaikh@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=james@ettle.org.uk \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox