From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Shaikh, Azhar" <azhar.shaikh@intel.com>
Cc: Javier Martinez Canillas <javierm@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
James Ettle <james@ettle.org.uk>,
Hans de Goede <hdegoede@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>
Subject: Re: [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag
Date: Wed, 20 Dec 2017 11:10:05 -0700 [thread overview]
Message-ID: <20171220181005.GC22908@ziepe.ca> (raw)
In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF5828988730@ORSMSX109.amr.corp.intel.com>
On Wed, Dec 20, 2017 at 03:19:19PM +0000, Shaikh, Azhar wrote:
> >This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
> >systems, but the only way this can happen is if the code is not correct.
> >
> >So it's an unnecessary check that just makes the code harder to read.
>
> This code was implemented as a suggestion from Jason on the previous patches.
> https://www.spinics.net/lists/linux-integrity/msg00827.html
The concept was to be like ASSERT_RTNL, maybe it just needs a suitably
named static inline to addrress Javier's readability concerns?
Jason
next prev parent reply other threads:[~2017-12-20 18:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 11:35 [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Javier Martinez Canillas
2017-12-20 11:35 ` [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region Javier Martinez Canillas
2017-12-20 15:25 ` Shaikh, Azhar
2017-12-20 18:08 ` Jason Gunthorpe
2017-12-20 18:21 ` Javier Martinez Canillas
2017-12-20 18:54 ` Jason Gunthorpe
2017-12-20 19:15 ` Shaikh, Azhar
2017-12-21 12:48 ` Javier Martinez Canillas
2017-12-21 15:39 ` Shaikh, Azhar
2017-12-21 15:53 ` Javier Martinez Canillas
2017-12-21 16:34 ` Shaikh, Azhar
2017-12-22 18:35 ` Jarkko Sakkinen
2017-12-24 20:57 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag Javier Martinez Canillas
2017-12-20 15:19 ` Shaikh, Azhar
2017-12-20 18:10 ` Jason Gunthorpe [this message]
2017-12-20 18:26 ` Javier Martinez Canillas
2017-12-22 18:38 ` Jarkko Sakkinen
2017-12-22 18:33 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 3/4] tpm: follow coding style for variable declaration in tpm_tis_core_init() Javier Martinez Canillas
2017-12-22 18:32 ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 4/4] tpm: only attempt to disable the LPC CLKRUN if is already enabled Javier Martinez Canillas
2017-12-22 18:36 ` Jarkko Sakkinen
2017-12-20 11:43 ` [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Hans de Goede
2017-12-20 12:12 ` Javier Martinez Canillas
2017-12-20 14:07 ` Alexander.Steffen
2017-12-20 14:35 ` Javier Martinez Canillas
2017-12-20 15:08 ` Shaikh, Azhar
2017-12-20 15:31 ` Javier Martinez Canillas
2017-12-20 15:41 ` Shaikh, Azhar
2017-12-20 16:45 ` Javier Martinez Canillas
2017-12-20 17:44 ` Jason Gunthorpe
2017-12-20 18:33 ` Javier Martinez Canillas
2017-12-22 18:39 ` Jarkko Sakkinen
2017-12-21 10:51 ` James Ettle
2017-12-21 12:46 ` Javier Martinez Canillas
2017-12-21 17:25 ` Jeffery Miller
2017-12-21 18:44 ` Javier Martinez Canillas
2017-12-21 19:02 ` Jeffery Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220181005.GC22908@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=arnd@arndb.de \
--cc=azhar.shaikh@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=james@ettle.org.uk \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox