RE: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region

Shaikh, Azhar
2017-12-21T16:34:18Z

>-----Original Message-----
>From: Javier Martinez Canillas [mailto:javierm@redhat.com]
>Sent: Thursday, December 21, 2017 7:54 AM
>To: Shaikh, Azhar <azhar.shaikh@intel.com>; Jason Gunthorpe
><jgg@ziepe.ca>
>Cc: linux-kernel@vger.kernel.org; James Ettle <james@ettle.org.uk>; Hans de
>Goede <hdegoede@redhat.com>; Arnd Bergmann <arnd@arndb.de>; Jarkko
>Sakkinen <jarkko.sakkinen@linux.intel.com>; Peter Huewe
><peterhuewe@gmx.de>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; linux-integrity@vger.kernel.org
>Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O
>memory region
>
>On 12/21/2017 04:39 PM, Shaikh, Azhar wrote:
>> HI Javier,
>>
>>
>>> -----Original Message-----
>>> From: linux-integrity-owner@vger.kernel.org [mailto:linux-integrity-
>>> owner@vger.kernel.org] On Behalf Of Javier Martinez Canillas
>>> Sent: Thursday, December 21, 2017 4:49 AM
>>> To: Shaikh, Azhar <azhar.shaikh@intel.com>; Jason Gunthorpe
>>> <jgg@ziepe.ca>
>>> Cc: linux-kernel@vger.kernel.org; James Ettle <james@ettle.org.uk>;
>>> Hans de Goede <hdegoede@redhat.com>; Arnd Bergmann
><arnd@arndb.de>;
>>> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>; Peter Huewe
>>> <peterhuewe@gmx.de>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>;
>>> linux-integrity@vger.kernel.org
>>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already
>>> unmapped I/O memory region
>>>
>>> Hello Azhar,
>>>
>>> On 12/20/2017 08:15 PM, Shaikh, Azhar wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Jason Gunthorpe [mailto:jgg@ziepe.ca]
>>>>> Sent: Wednesday, December 20, 2017 10:55 AM
>>>>> To: Javier Martinez Canillas <javierm@redhat.com>
>>>>> Cc: linux-kernel@vger.kernel.org; James Ettle <james@ettle.org.uk>;
>>>>> Hans de Goede <hdegoede@redhat.com>; Shaikh, Azhar
>>>>> <azhar.shaikh@intel.com>; Arnd Bergmann <arnd@arndb.de>; Jarkko
>>>>> Sakkinen <jarkko.sakkinen@linux.intel.com>; Peter Huewe
>>>>> <peterhuewe@gmx.de>; Greg Kroah-Hartman
>>> <gregkh@linuxfoundation.org>;
>>>>> linux- integrity@vger.kernel.org
>>>>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already
>>>>> unmapped I/O memory region
>>>>>
>>>>> On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas
>wrote:
>>>>>
>>>>>>> The below draft fixes everything except #1. That needs a more
>>>>>>> thoughtful idea..
>>>>>>>
>>>>>>
>>>>>> I'll just drop this patch from the series and you can fix all the
>>>>>> issues in the error / driver removal paths. It's not a dependency
>>>>>> anyways, I included it just because noticed the issue while
>>>>>> reading the
>>> code.
>>>>>
>>>>> Azhar, this means it becomes your problem :)
>>>>>
>>>>
>>>> Sure, I will fix this.
>>>> Javier you can drop this patch.
>>>>
>>>
>>> On a second though, we should just merge $SUBJECT since is an obvious
>>> fix for one of the issues. Then you could fix the remaining bugs in
>>> error and driver removal paths.
>>
>> I think you are asking to keep this patch as a part of this series, itself and not
>upload separately. Is this correct? Please correct me if I am wrong.
>>
>
>Yes, what I meant is that we should just keep this patch in the series since it
>fixes one of the resource cleanup bugs. Then you can fix the other issues as a
>follow-up.
>

Ok, but even the patch which I will be submitting will be doing the cleanup. So it will just split the change.

>Best regards,
>--
>Javier Martinez Canillas
>Software Engineer - Desktop Hardware Enablement Red Hat

Regards,
Azhar Shaikh