Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region

Jarkko Sakkinen
2017-12-24T20:57:57Z

On Wed, Dec 20, 2017 at 12:35:35PM +0100, Javier Martinez Canillas wrote:
> The driver maps the I/O memory address to control the LPC bus CLKRUN_EN,
> but on the error path the memory is accessed by the .clk_enable handler
> after this was already unmapped. So only unmap the I/O memory region if
> it will not be used anymore.
>
> Also, the correct thing to do is to cleanup the resources in the inverse
> order that were acquired to prevent issues like these.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

I applied Azhar's updated patches to master and next. Shouldn't this be
dropped now?

/Jarkko