From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-integrity-owner@vger.kernel.org>
Received: from mga14.intel.com ([192.55.52.115]:23032 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753228AbeARR7w (ORCPT <rfc822;linux-integrity@vger.kernel.org>);
        Thu, 18 Jan 2018 12:59:52 -0500
Date: Thu, 18 Jan 2018 19:59:48 +0200
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Alexander Steffen <Alexander.Steffen@infineon.com>
Cc: nayna@linux.vnet.ibm.com, kgold@linux.vnet.ibm.com,
        linux-integrity@vger.kernel.org
Subject: Re: [RFC][PATCH 3/9] tpm_tis_core: correctly wait for flags to
 become zero
Message-ID: <20180118175948.dwyinkqx5bvff44o@linux.intel.com>
References: <20171208184658.9588-1-Alexander.Steffen@infineon.com>
 <20171208184658.9588-4-Alexander.Steffen@infineon.com>
 <20180118175832.qrxoz6q4nyjkyp3l@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <20180118175832.qrxoz6q4nyjkyp3l@linux.intel.com>
Sender: linux-integrity-owner@vger.kernel.org
List-ID: <linux-integrity.vger.kernel.org>

On Thu, Jan 18, 2018 at 07:58:32PM +0200, Jarkko Sakkinen wrote:
> On Fri, Dec 08, 2017 at 07:46:52PM +0100, Alexander Steffen wrote:
> > According to TIS/PTP the dataAvail flag and the Expect flag in the STS
> > register contain valid values if and only if the stsValid flag in the same
> > register is set. Currently, the code first waits for the stsValid flag to
> > be set and then looks at the other flags. This causes the STS register to
> > be read twice, so that the stsValid flag might not be set anymore when the
> > other flags are evaluated.
> > 
> > Other parts of the code already check both flags in a single operation
> > within wait_for_tpm_stat. But the current implementation can only check for
> > flags being set to 1, not 0. Therefore, add a parameter to
> > wait_for_tpm_stat that allows to specify the expected value in addition to
> > the selected flags and adapt all callers accordingly.
> > 
> > In addition, this now checks the dataAvail and Expect flags multiple times
> > within the specified timeout, so those flags no longer need to have the
> > expected value right away. This is important for example when sending large
> > amounts of data to the TPM, when the TPM might not process its I/O buffer
> > fast enough for the flags to be set correctly when they are checked for the
> > first time.
> > 
> > Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com>
> 
> LGTM
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> /Jarkko

Ugh, was meant for 4/9 :-) Ignore this.

/Jarkko