From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Alexander Steffen <Alexander.Steffen@infineon.com>
Cc: linux-integrity@vger.kernel.org
Subject: Re: [RFC][PATCH 1/3] tpm-chip: Move idr_replace calls to appropriate places
Date: Thu, 18 Jan 2018 20:41:34 +0200 [thread overview]
Message-ID: <20180118184134.qac6sewefbbvcxka@linux.intel.com> (raw)
In-Reply-To: <20171214160614.11808-2-Alexander.Steffen@infineon.com>
On Thu, Dec 14, 2017 at 05:06:12PM +0100, Alexander Steffen wrote:
> According to the comments, adding/removing the chip from the list should be
> the first/last action in (un)register. But currently it is done in a
> subfunction in the middle of the process. Moving the code from the
> subfunctions to the appropriate places within (un)register ensures that the
> code matches the comments.
>
> Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com>
NAK
Not compatible with init_module().
http://man7.org/linux/man-pages/man2/init_module.2.html
/Jarkko
next prev parent reply other threads:[~2018-01-18 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 16:06 [RFC][PATCH 0/3] Export broken TPMs to user space Alexander Steffen
2017-12-14 16:06 ` [RFC][PATCH 1/3] tpm-chip: Move idr_replace calls to appropriate places Alexander Steffen
2017-12-14 19:27 ` Jason Gunthorpe
2017-12-15 9:26 ` Alexander.Steffen
2018-01-18 18:38 ` Jarkko Sakkinen
2018-01-18 18:41 ` Jarkko Sakkinen [this message]
2017-12-14 16:06 ` [RFC][PATCH 2/3] tpm-chip: Return TPM error codes from auto_startup functions Alexander Steffen
2017-12-14 16:06 ` [RFC][PATCH 3/3] tpm-chip: Export TPM device to user space even when startup failed Alexander Steffen
2017-12-14 19:28 ` Jason Gunthorpe
2018-01-18 18:45 ` Jarkko Sakkinen
2018-01-18 19:24 ` Jason Gunthorpe
2018-01-23 12:39 ` Jarkko Sakkinen
2017-12-15 14:47 ` [RFC][PATCH 0/3] Export broken TPMs to user space Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118184134.qac6sewefbbvcxka@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=linux-integrity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).