From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:35041 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbeCZUJk (ORCPT ); Mon, 26 Mar 2018 16:09:40 -0400 Date: Mon, 26 Mar 2018 23:09:36 +0300 From: Jarkko Sakkinen To: Tomas Winkler Cc: Jason Gunthorpe , Alexander Usyskin , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4] tpm: separate cmd_ready/go_idle from runtime_pm Message-ID: <20180326200936.GA3810@linux.intel.com> References: <20180324183935.20784-1-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180324183935.20784-1-tomas.winkler@intel.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Sat, Mar 24, 2018 at 09:39:35PM +0300, Tomas Winkler wrote: > From: "Winkler, Tomas" > > We cannot use go_idle cmd_ready commands via runtime_pm handles > as with the introduction of localities this is no longer an optional > feature, while runtime pm can be not enabled. > Though cmd_ready/go_idle provides power saving feature, it's also part of > TPM2 protocol and should be called explicitly. > This patch exposes cmd_read/go_idle via tpm class ops and removes > runtime pm support as it is not used by any driver. > > tpm_crb no longer needs own power saving functions and can drop using > tpm_pm_suspend/resume. > > Signed-off-by: Tomas Winkler Still fails on Kabylake exactly the same way. With this I get RC_UNBALANCED in these four test cases: test_flush_context (tpm2_smoke.SpaceTest) ... ERROR test_get_handles (tpm2_smoke.SpaceTest) ... ERROR test_make_two_spaces (tpm2_smoke.SpaceTest) ... ERROR Without this patch applied these errors do not occur. /Jarkko