From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: jarkko.sakkinen@linux.intel.com, linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm: add support for nonblocking operation
Date: Fri, 1 Jun 2018 11:17:31 -0600 [thread overview]
Message-ID: <20180601171731.GF1408@ziepe.ca> (raw)
In-Reply-To: <e631c9e7-fe2c-061b-fcb9-aea583285746@intel.com>
On Fri, Jun 01, 2018 at 09:55:52AM -0700, Tadeusz Struk wrote:
> On 06/01/2018 07:37 AM, Jason Gunthorpe wrote:
> >> +struct tpm_dev_work {
> >> + struct work_struct work;
> >> + struct file_priv *priv;
> >> + struct tpm_space *space;
> >> + ssize_t resp_size;
> >> + bool nonblocking;
> >> +};
> > There can only be one operation going at once, so why not put this in
> > the file_priv? Which might be needed because..
>
> I need the *space as well, which doesn't really belong to file_priv
> that's why I added this new struct. You are right the file_priv
> isn't really needed here. I used it to have the priv->data_pending
> but I can have just a ptr to data_pending in tpm_dev_work.
I mean in the sense that each file_priv can have exactly one async
work outstanding, so you can just add this struct to file_priv instead
of allocing it everytime..
Jason
next prev parent reply other threads:[~2018-06-01 17:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 23:29 [PATCH] tpm: add support for nonblocking operation Tadeusz Struk
2018-06-01 14:37 ` Jason Gunthorpe
2018-06-01 16:55 ` Tadeusz Struk
2018-06-01 17:17 ` Jason Gunthorpe [this message]
2018-06-12 0:20 ` [PATCH v2 0/2] " Tadeusz Struk
2018-06-12 0:20 ` [PATCH v2 1/2] tpm: add ptr to the tpm_space struct to file_priv Tadeusz Struk
2018-06-12 0:20 ` [PATCH v2 2/2] tpm: add support for nonblocking operation Tadeusz Struk
2018-06-12 2:53 ` kbuild test robot
2018-06-12 4:46 ` Tadeusz Struk
2018-06-12 17:39 ` Tadeusz Struk
2018-06-04 19:55 ` [PATCH] " Jarkko Sakkinen
2018-06-04 19:56 ` Jarkko Sakkinen
2018-06-08 19:36 ` flihp
2018-06-12 0:13 ` Tadeusz Struk
2018-06-18 18:26 ` Jarkko Sakkinen
2018-06-12 1:43 ` James Bottomley
2018-06-18 18:25 ` Jarkko Sakkinen
2018-07-05 23:15 ` flihp
2018-07-16 17:34 ` Jarkko Sakkinen
2018-07-16 20:10 ` Tadeusz Struk
2018-07-23 17:38 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601171731.GF1408@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox