From: Jason Gunthorpe <jgg@ziepe.ca>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko.sakkine@linux.intel.com>,
linux-integrity@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] tpm_tis_spi: Pass the SPI IRQ down to the driver
Date: Fri, 8 Jun 2018 09:50:23 -0600 [thread overview]
Message-ID: <20180608155023.GA12577@ziepe.ca> (raw)
In-Reply-To: <20180608070209.14769-1-linus.walleij@linaro.org>
On Fri, Jun 08, 2018 at 09:02:09AM +0200, Linus Walleij wrote:
> An SPI TPM device managed directly on an embedded board using
> the SPI bus and some GPIO or similar line as IRQ handler will
> pass the IRQn from the TPM device associated with the SPI
> device. This is already handled by the SPI core, so make sure
> to pass this down to the core as well.
>
> (The TPM core habit of using -1 to signal no IRQ is dubious
> (as IRQ 0 is NO_IRQ) but I do not want to mess with that
> semantic in this patch.)
Unless something has changed, there is no cross-arch constant called
NO_IRQ, and the few arches that do define it, tend to use -1..
Jason
next prev parent reply other threads:[~2018-06-08 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 7:02 [PATCH] tpm_tis_spi: Pass the SPI IRQ down to the driver Linus Walleij
2018-06-08 15:50 ` Jason Gunthorpe [this message]
2018-06-10 11:57 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2018-06-08 7:09 Linus Walleij
2018-06-18 18:08 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608155023.GA12577@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=broonie@kernel.org \
--cc=jarkko.sakkine@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox