From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org,
Thorsten Leemhuis <regressions@leemhuis.info>,
Nayna Jain <nayna@linux.vnet.ibm.com>
Subject: Re: [PATCH] tpm.h: increase poll timings to fix tpm_tis regression
Date: Mon, 16 Jul 2018 23:16:34 +0300 [thread overview]
Message-ID: <20180716201634.GA15123@linux.intel.com> (raw)
In-Reply-To: <1531336133.3260.16.camel@HansenPartnership.com>
On Wed, Jul 11, 2018 at 12:08:53PM -0700, James Bottomley wrote:
> Yes, I wondered about this, but I don't understand the bus protocol
> well enough. The tpm-interface:tpm_try_transmit() which throws the
> first ETIME says after we get that we send chip->ops->cancel() which
> tpm_tis simply translates to tpm_tis_ready() which also times out. Is
> there a bigger hammer I can hit it with?
tpm_tis_ready() gets called twice and it is unsynced (no wait). Maybe
this confuses the chip somehow?
/Jarkko
prev parent reply other threads:[~2018-07-16 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 17:04 Regression in tpm_tis driver: the TPM now fatally offlines itself after a few hours of use James Bottomley
2018-07-11 17:11 ` [PATCH] tpm.h: increase poll timings to fix tpm_tis regression James Bottomley
2018-07-11 18:21 ` Jason Gunthorpe
2018-07-11 19:08 ` James Bottomley
2018-07-11 20:01 ` Jason Gunthorpe
2018-07-11 20:39 ` James Bottomley
2018-07-11 20:51 ` Peter Huewe
2018-07-11 20:54 ` James Bottomley
2018-07-11 21:06 ` Jason Gunthorpe
2018-07-16 20:16 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716201634.GA15123@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=regressions@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox