From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:57970 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728458AbeHNSxx (ORCPT ); Tue, 14 Aug 2018 14:53:53 -0400 Date: Tue, 14 Aug 2018 19:06:05 +0300 From: Jarkko Sakkinen To: Tadeusz Struk Cc: flihp@twobit.us, jgg@ziepe.ca, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] tpm: add ptr to the tpm_space struct to file_priv Message-ID: <20180814160605.GC13648@linux.intel.com> References: <153419236870.8189.15489652816512817246.stgit@tstruk-mobl1.jf.intel.com> <153419237378.8189.17192381683473461307.stgit@tstruk-mobl1.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <153419237378.8189.17192381683473461307.stgit@tstruk-mobl1.jf.intel.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Mon, Aug 13, 2018 at 01:32:53PM -0700, Tadeusz Struk wrote: > Add a ptr to struct tpm_space to the file_priv to have an easy > access to it in the async job without the need to allocate memory. > This also allows to consolidate of the write operations for > the two interfaces. > > Tested-by: Philip Tricca > Signed-off-by: Tadeusz Struk NAK A rule thumb: do not add "links" between commits unless it is you cannot find any other way. The cover letter is made for describing feature or features that are defined a the set of commits. What is "async job" anyway? It is a bogus term. Please refer to only merged code in your commit message, not futures. /Jarkko