Re: [PATCH 01/23] TPM: Add new TPMs to the tail of the list to prevent inadvertent change of dev

Mimi Zohar
2018-08-24T14:57:11Z

On Fri, 2018-08-24 at 09:25 +0300, Jarkko Sakkinen wrote:
> On Fri, Aug 24, 2018 at 09:24:34AM +0300, Jarkko Sakkinen wrote:
> > On Tue, Aug 21, 2018 at 12:30:04PM -0600, Jason Gunthorpe wrote:
> > > On Tue, Aug 21, 2018 at 04:56:56PM +0100, David Howells wrote:
> > > > Add newly registered TPMs to the tail of the list, not the beginning, so that
> > > > things that are specifying TPM_ANY_NUM don't find that the device they're
> > > > using has inadvertently changed. Adding a second device would break IMA, for
> > > > instance.
> > > >
> > > > Signed-off-by: David Howells <dhowells@redhat.com>
> > > > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> > > > cc: stable@vger.kernel.org
> > > > ---
> > >
> > > We really should apply this patch...
> > >
> > > Jason
> >
> > This is the first time I remember seeing it.
>
> At least in the sense that I should review it.

I remember this patch, because it affected IMA. It has already been
upstreamed as 398a1e71dc82.

Mimi