From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:58503 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730026AbeISA2s (ORCPT ); Tue, 18 Sep 2018 20:28:48 -0400 Date: Tue, 18 Sep 2018 21:54:33 +0300 From: Jarkko Sakkinen To: Roberto Sassu Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] tpm: retrieve digest size of unknown algorithms with PCR read Message-ID: <20180918185433.GA9177@linux.intel.com> References: <20180905114202.7757-1-roberto.sassu@huawei.com> <20180905114202.7757-4-roberto.sassu@huawei.com> <20180916123749.GF5040@linux.intel.com> <322eb81b-3f3e-e37e-5fb0-a37aad3d06d7@huawei.com> <20180917211622.GC6716@linux.intel.com> <8621eb6d-b252-4fb3-cb67-294f0aafb54c@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <8621eb6d-b252-4fb3-cb67-294f0aafb54c@huawei.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Tue, Sep 18, 2018 at 09:14:43AM +0200, Roberto Sassu wrote: > On 9/17/2018 11:16 PM, Jarkko Sakkinen wrote: > > On Mon, Sep 17, 2018 at 12:02:56PM +0200, Roberto Sassu wrote: > > > This code has the same behavior of tpm2_get_pcr_allocation(). If some > > > banks are not used, set the algorithm of the first unused to > > > TPM_ALG_ERROR. > > > > My point is that maybe it would sense to use zero for that in order > > to make code a bit simpler. > > Wouldn't be better to compare data with the same type? Since the alg_id > structure member stores an algorithm, it should be fine to compare its > value with an algorithm. > > No problem to change that, but probably I should modify also > tpm_pcr_extend(). > > Roberto Please do. /Jarkko