From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:13544 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731253AbeISUpk (ORCPT ); Wed, 19 Sep 2018 16:45:40 -0400 Date: Wed, 19 Sep 2018 18:07:06 +0300 From: Jarkko Sakkinen To: Tomas Winkler Cc: Jason Gunthorpe , Alexander Usyskin , Tadeusz Struk , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 11/20] tpm: factor out tpm_startup function Message-ID: <20180919150706.GE31076@linux.intel.com> References: <20180918093459.19165-1-tomas.winkler@intel.com> <20180918093459.19165-12-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180918093459.19165-12-tomas.winkler@intel.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Tue, Sep 18, 2018 at 12:34:50PM +0300, Tomas Winkler wrote: > tpm manual startup is used only from within tpm1 or tpm2 > code, hence remove tpm_startup function from tpm-interface.c > and add two static functions implementations tpm1_startup > and tpm2_startup into to tpm1-cmd.c and tpm2-cmd.c respectively. > > Signed-off-by: Tomas Winkler Again, language in the commit message. For example, I guess usually we write abbrevation "TPM" and not "tpm". Tested-by: Jarkko Sakkine /Jarkko