linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-integrity@vger.kernel.org
Subject: Re: TPM2_RC_TESTING and tpm_transmit_cmd
Date: Tue, 29 Jan 2019 15:48:40 +0200	[thread overview]
Message-ID: <20190129134840.GA5573@linux.intel.com> (raw)
In-Reply-To: <20190122202159.ktlrxewwr7vryayc@cantor>

On Tue, Jan 22, 2019 at 01:21:59PM -0700, Jerry Snitselaar wrote:
> Would it make sense to filter out TPM2_RC_TESTING when reporting an error
> in tpm_transmit_cmd, or possibly spitting out a follow on message in
> the selftest code that the tpm is still testing?
> 
> Had a bz opened here because someone had the error message in their logs,
> and I can see how it would be confusing. We have the intermittent selftest
> patch already so it should be functioning, but just wondering if not
> printing out that error message would make sense.
> 
> Regards,
> Jerry

Yes, I think so. The caller can decide to print something in this case.

/Jarkko

      reply	other threads:[~2019-01-29 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 20:21 TPM2_RC_TESTING and tpm_transmit_cmd Jerry Snitselaar
2019-01-29 13:48 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129134840.GA5573@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jsnitsel@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).