From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: linux-integrity@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] tpm: don't return bool from update_timeouts
Date: Tue, 29 Jan 2019 21:22:05 +0200 [thread overview]
Message-ID: <20190129192205.GA14305@linux.intel.com> (raw)
In-Reply-To: <20190129174145.1482-2-jsnitsel@redhat.com>
On Tue, Jan 29, 2019 at 10:41:45AM -0700, Jerry Snitselaar wrote:
> Set tpm_chip->timeouts_adjusted directly in the update_timeouts
> code instead of returning bool. Return rc of tpm read instead,
> which can be return an error in the case of the spi driver.
>
> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
Couple of remarks:
1. Shouldn't it then be just void?
2. Why do we even need timeout_adjusted in struct tpm_chip [1]?
[1] Only used locally in tpm1_get_timeouts().
/Jarkko
next prev parent reply other threads:[~2019-01-29 19:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 17:41 [RFC PATCH 0/1] tpm: don't return bool from update_timeouts Jerry Snitselaar
2019-01-29 17:41 ` [RFC PATCH 1/1] " Jerry Snitselaar
2019-01-29 19:22 ` Jarkko Sakkinen [this message]
2019-01-29 19:50 ` Jerry Snitselaar
2019-01-29 21:12 ` Jarkko Sakkinen
2019-01-29 18:31 ` [RFC PATCH 0/1] " Jarkko Sakkinen
2019-01-29 20:14 ` [RFC PATCH v2 1/1] " Jerry Snitselaar
2019-01-30 21:23 ` Jarkko Sakkinen
2019-01-30 21:24 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129192205.GA14305@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).