From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6407AC169C4 for ; Tue, 29 Jan 2019 19:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33F6C20856 for ; Tue, 29 Jan 2019 19:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbfA2T3p (ORCPT ); Tue, 29 Jan 2019 14:29:45 -0500 Received: from mga03.intel.com ([134.134.136.65]:31044 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726852AbfA2T3o (ORCPT ); Tue, 29 Jan 2019 14:29:44 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 11:29:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,537,1539673200"; d="scan'208";a="129911349" Received: from rkazants-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.254.212]) by orsmga002.jf.intel.com with ESMTP; 29 Jan 2019 11:29:38 -0800 Date: Tue, 29 Jan 2019 21:29:41 +0200 From: Jarkko Sakkinen To: Roberto Sassu Cc: zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com, matthewgarrett@google.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v8 1/7] tpm: dynamically allocate the allocated_banks array Message-ID: <20190129192941.GB14305@linux.intel.com> References: <20190124154910.29948-1-roberto.sassu@huawei.com> <20190124154910.29948-2-roberto.sassu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190124154910.29948-2-roberto.sassu@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Jan 24, 2019 at 04:49:04PM +0100, Roberto Sassu wrote: > + chip->allocated_banks = kcalloc(1, sizeof(*chip->allocated_banks), > + GFP_KERNEL); > + if (!chip->allocated_banks) { > + rc = -ENOMEM; > + goto out; > + } > + > + chip->allocated_banks[0] = TPM2_ALG_SHA1; > + chip->nr_allocated_banks = 1; Everything else looks nice in this patch except this. You always branch for TPM 1.2, and it will always have just SHA1. This is unnecessary. /Jarkko