From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911F7C282D7 for ; Wed, 30 Jan 2019 21:23:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BAA3218AF for ; Wed, 30 Jan 2019 21:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730868AbfA3VXH (ORCPT ); Wed, 30 Jan 2019 16:23:07 -0500 Received: from mga09.intel.com ([134.134.136.24]:43406 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727165AbfA3VXH (ORCPT ); Wed, 30 Jan 2019 16:23:07 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 13:23:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,542,1539673200"; d="scan'208";a="271255452" Received: from unknown (HELO localhost) ([10.249.254.216]) by orsmga004.jf.intel.com with ESMTP; 30 Jan 2019 13:23:04 -0800 Date: Wed, 30 Jan 2019 23:23:03 +0200 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-integrity@vger.kernel.org Subject: Re: [RFC PATCH v2 1/1] tpm: don't return bool from update_timeouts Message-ID: <20190130212303.GB17308@linux.intel.com> References: <20190129174145.1482-1-jsnitsel@redhat.com> <20190129201415.739-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129201415.739-1-jsnitsel@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Jan 29, 2019 at 01:14:15PM -0700, Jerry Snitselaar wrote: > Set tpm_chip->timeouts_adjusted directly in the update_timeouts > code instead of returning bool. In case of tpm read failing > print warning that the read failed and continue on. > > Signed-off-by: Jerry Snitselaar Reviewed-by: Jarkko Sakkinen /Jarkko