From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A66C282D9 for ; Thu, 31 Jan 2019 16:07:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEC142085B for ; Thu, 31 Jan 2019 16:07:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388072AbfAaQHS (ORCPT ); Thu, 31 Jan 2019 11:07:18 -0500 Received: from mga12.intel.com ([192.55.52.136]:62377 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733167AbfAaQHS (ORCPT ); Thu, 31 Jan 2019 11:07:18 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 08:07:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,545,1539673200"; d="scan'208";a="112663281" Received: from rkazants-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.254.212]) by orsmga006.jf.intel.com with ESMTP; 31 Jan 2019 08:07:15 -0800 Date: Thu, 31 Jan 2019 18:07:13 +0200 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] tpm: don't return bool from update_timeouts Message-ID: <20190131160713.GD5629@linux.intel.com> References: <20190130220659.10102-1-jsnitsel@redhat.com> <20190131160645.GC5629@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131160645.GC5629@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Jan 31, 2019 at 06:06:45PM +0200, Jarkko Sakkinen wrote: > On Wed, Jan 30, 2019 at 03:06:58PM -0700, Jerry Snitselaar wrote: > > Set tpm_chip->timeouts_adjusted directly in the update_timeouts > > code instead of returning bool. In case of tpm read failing > > print warning that the read failed and continue on. > > > > Reviewed-by: Jarkko Sakkinen > > Signed-off-by: Jerry Snitselaar > > Your signed-off-by should be before my reviewed-by (no need to > resend). ... and linux-security-module is missing (need to resend). /Jarkko