From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA88BC282C4 for ; Mon, 4 Feb 2019 23:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B872F2082E for ; Mon, 4 Feb 2019 23:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727166AbfBDXky (ORCPT ); Mon, 4 Feb 2019 18:40:54 -0500 Received: from mga09.intel.com ([134.134.136.24]:38052 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbfBDXky (ORCPT ); Mon, 4 Feb 2019 18:40:54 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2019 15:40:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,560,1539673200"; d="scan'208";a="140669778" Received: from baparham-mobl.amr.corp.intel.com (HELO localhost) ([10.249.254.152]) by fmsmga002.fm.intel.com with ESMTP; 04 Feb 2019 15:40:48 -0800 Date: Tue, 5 Feb 2019 01:40:47 +0200 From: Jarkko Sakkinen To: Roberto Sassu , jgg@ziepe.ca Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, zohar@linux.ibm.com, stable@vger.kernel.org Subject: Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon Message-ID: <20190204234047.GA15685@linux.intel.com> References: <20190204133749.14176-1-jarkko.sakkinen@linux.intel.com> <575f4693-129c-469c-e54e-dbb9ad2a66f2@huawei.com> <20190204233117.GE14992@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204233117.GE14992@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Feb 05, 2019 at 01:31:17AM +0200, Jarkko Sakkinen wrote: > On Mon, Feb 04, 2019 at 02:49:54PM +0100, Roberto Sassu wrote: > > On 2/4/2019 2:37 PM, Jarkko Sakkinen wrote: > > > Rename TPM_BUFSIZE defined in drivers/char/tpm/st33zp24/st33zp24.h to > > > ST33ZP24_BUFSIZE. > > > > > > Rename TPM_BUFSIZE defined in drivers/char/tpm/tpm_i2c_infineon.c to > > > TPM_I2C_INFINEON_BUFSIZE. > > > > Please also add a prefix to TPM_RETRY in tpm_i2c_nuvoton.c. > > Thanks, can do. TPM_RETRY defined in 32d33b29ba07 ("TPM: Retry SaveState command in suspend path") has nothing to do with time. I'll also remove the comment about 5 seconds. The definitions for TPM_RETRY seem fairly arbitrary. Jason, could tpm_i2c_nuvoton also use the same constant as tpm_tis_spi and TPM 1.2 suspend, try max 50 times instead of five? /Jarkko