From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0513BC282D7 for ; Mon, 11 Feb 2019 19:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA50F2229F for ; Mon, 11 Feb 2019 19:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="ftUZgy/F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387615AbfBKTJa (ORCPT ); Mon, 11 Feb 2019 14:09:30 -0500 Received: from mail.skyhub.de ([5.9.137.197]:50180 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387609AbfBKTJ2 (ORCPT ); Mon, 11 Feb 2019 14:09:28 -0500 Received: from zn.tnic (p200300EC2BC7A10074DEFDFE3AD6CF32.dip0.t-ipconnect.de [IPv6:2003:ec:2bc7:a100:74de:fdfe:3ad6:cf32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 68D731EC01AF; Mon, 11 Feb 2019 20:09:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1549912166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=VpYmZSs9sbABUSNGoL/C0ayKwiKyD+m0wtsCebUKB6U=; b=ftUZgy/FPSTtySgYJ/UzFVeGCOsODAUsQKs6K7XANHrF+gDY4HvEaU0p6A1LhGKT6EUnng b4j2CPf+XzUIaOcE3tYhupgHOaZAiAnPwo8lm1rv4Oxwx4Extm8w3wUNJbLb18kXMeVTiC oIFMgrDwuw+4dp01dYzWJPpzr2HxZQE= Date: Mon, 11 Feb 2019 20:09:25 +0100 From: Borislav Petkov To: Rick Edgecombe Cc: Andy Lutomirski , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, Thomas Gleixner , Nadav Amit , Dave Hansen , Peter Zijlstra , linux_dti@icloud.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, akpm@linux-foundation.org, kernel-hardening@lists.openwall.com, linux-mm@kvack.org, will.deacon@arm.com, ard.biesheuvel@linaro.org, kristen@linux.intel.com, deneen.t.dock@intel.com Subject: Re: [PATCH v2 13/20] Add set_alias_ function and x86 implementation Message-ID: <20190211190925.GQ19618@zn.tnic> References: <20190129003422.9328-1-rick.p.edgecombe@intel.com> <20190129003422.9328-14-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190129003422.9328-14-rick.p.edgecombe@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, Jan 28, 2019 at 04:34:15PM -0800, Rick Edgecombe wrote: > This adds two new functions set_alias_default_noflush and s/This adds/Add/ > set_alias_nv_noflush for setting the alias mapping for the page to its Please end function names with parentheses, below too. > default valid permissions and to an invalid state that cannot be cached in > a TLB, respectively. These functions to not flush the TLB. s/to/do/ Also, pls put that description as comments over the functions in the code. Otherwise that "nv" as part of the name doesn't really explain what it does. Actually, you could just as well call the function set_alias_invalid_noflush() All the other words are written in full, no need to have "nv" there. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.