From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Matthew Garrett <mjg59@google.com>
Cc: linux-integrity <linux-integrity@vger.kernel.org>,
peterhuewe@gmx.de, jgg@ziepe.ca,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH V2 2/4] tpm: Reserve the TPM final events table
Date: Wed, 13 Feb 2019 01:11:54 +0200 [thread overview]
Message-ID: <20190212231154.GC3977@linux.intel.com> (raw)
In-Reply-To: <CACdnJut2tNMZvjyc=TxaxRQiuj-Xjb1pyTZgHOYxkPO-VKYM1w@mail.gmail.com>
On Mon, Feb 11, 2019 at 12:58:21PM -0800, Matthew Garrett wrote:
> > Wondering that should this function instead do right `in the beginning:
> >
> > if (efi.tpm_log == EFI_INVALID_TABLE_ADDR &&
> > efi.tpm_final_log == EFI_INVALID_TABLE_ADDR)
> > return 0;
> >
> > Feels odd condition that the log would not be invalid but the post log
> > (using post would be more self-describing than final imho) would be. Can
> > that legitly happen?
>
> The spec name is final, so I kept it that way for consistency. Keeping
> a separate check for the final event log is partly out of
> defensiveness against firmware implementations getting this wrong -
> I've definitely found implementations that just don't produce any
> final events, so it wouldn't surprise me if there are some that don't
> install the table.
OK, sounds very reasonable.
> Done. I'll send an updated patchset.
Awesome, thank you.
/Jarkko
next prev parent reply other threads:[~2019-02-12 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190204213303.131064-1-matthewgarrett@google.com>
2019-02-04 21:33 ` [PATCH V2 1/4] tpm: Abstract crypto agile event size calculations Matthew Garrett
2019-02-11 14:28 ` Jarkko Sakkinen
2019-02-11 14:35 ` Jarkko Sakkinen
2019-02-04 21:33 ` [PATCH V2 2/4] tpm: Reserve the TPM final events table Matthew Garrett
2019-02-11 16:38 ` Jarkko Sakkinen
2019-02-11 20:58 ` Matthew Garrett
2019-02-12 23:11 ` Jarkko Sakkinen [this message]
2019-02-04 21:33 ` [PATCH V2 3/4] tpm: Append the final event log to the TPM event log Matthew Garrett
2019-02-04 21:33 ` [PATCH V2 4/4] efi: Attempt to get the TCG2 event log in the boot stub Matthew Garrett
2019-02-05 9:27 ` your mail Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212231154.GC3977@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
--cc=peterhuewe@gmx.de \
--cc=roberto.sassu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).