From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A9CC43381 for ; Tue, 19 Feb 2019 11:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63008208E4 for ; Tue, 19 Feb 2019 11:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728292AbfBSL7Y (ORCPT ); Tue, 19 Feb 2019 06:59:24 -0500 Received: from mga02.intel.com ([134.134.136.20]:48593 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728280AbfBSL7Y (ORCPT ); Tue, 19 Feb 2019 06:59:24 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2019 03:59:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,388,1544515200"; d="scan'208";a="134642841" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.132]) by FMSMGA003.fm.intel.com with ESMTP; 19 Feb 2019 03:59:21 -0800 Date: Tue, 19 Feb 2019 13:59:21 +0200 From: Jarkko Sakkinen To: Matthew Garrett Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca, roberto.sassu@huawei.com Subject: Re: [PATCH V3] Add support for TPM2 event logs on EFI systems Message-ID: <20190219115921.GB29454@linux.intel.com> References: <20190211215518.81419-1-matthewgarrett@google.com> <20190219115652.GA29454@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219115652.GA29454@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Feb 19, 2019 at 01:56:52PM +0200, Jarkko Sakkinen wrote: > On Mon, Feb 11, 2019 at 01:55:14PM -0800, Matthew Garrett wrote: > > Updated with review feedback comments, no functional change. > > Tried to test with a Geminilake NUC but for some reason do not see the log > file with this machine. > > The final log *does* get reported: > > [ 0.000000] efi: ACPI 2.0=0x69ca2000 ACPI=0x69ca2000 TPMFinalLog=0x69ce4000 SMBIOS=0x69f63000 SMBIOS 3.0=0x69f62000 ESRT=0x69f3e818 MEMATTR=0x63474118 > > I'll try to debug this further later on. PS. Can you send the next version so that it gets CC'd to linux-security-module and main linux-kernel list or if we come to the conclusion that this patch set version is sufficient, do a resend (--subject-prefix="PATCH v3, RESEND")? Probably good timing is when I get this tested first... /Jarkko