From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: YueHaibing <yuehaibing@huawei.com>,
peterhuewe@gmx.de, arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH -next] tpm: change the return type of calc_tpm2_event_size to size_t
Date: Tue, 19 Feb 2019 19:31:20 +0200 [thread overview]
Message-ID: <20190219173120.GA15462@linux.intel.com> (raw)
In-Reply-To: <20190219163456.GB752@ziepe.ca>
On Tue, Feb 19, 2019 at 09:34:56AM -0700, Jason Gunthorpe wrote:
> > - Your real name is formatted incorrectly. It should be like "Yue Haibig"
> > as shown in [1].
> > - If there is no actual regression, this change is useless.
>
> Clarity of the code is a laudible goal - not everything is about
> fixing bugs or adding features.
>
> It is much easier to write the code properly than to try and prove
> that event_size can not exceed INT_MAX.
I think it is actually a regression in 4d23cc323cdb. Should carry a
fixes tag. I did not quite undersand what commit message was saying.
What it should would just
"""
tpm: Fix the type of the return value in calc_tpm2_event_size()
calc_tpm2_event_size() has an invalid signature because it returns a 'size_t'
where as its signature says that it returns 'int'.
"""
Should be also Cc'd to linux-security-module and have cc to stable.
/Jarkko
next prev parent reply other threads:[~2019-02-19 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 7:26 [PATCH -next] tpm: change the return type of calc_tpm2_event_size to size_t YueHaibing
2019-02-19 8:59 ` Jarkko Sakkinen
2019-02-19 9:15 ` YueHaibing
2019-02-19 10:35 ` Jarkko Sakkinen
2019-02-19 12:00 ` YueHaibing
2019-02-19 16:34 ` Jason Gunthorpe
2019-02-19 17:31 ` Jarkko Sakkinen [this message]
2019-02-20 2:13 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219173120.GA15462@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).