From: Stephen Hemminger <stephen@networkplumber.org>
To: "Sasha Levin" <sashal@kernel.org>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <peterhuewe@gmx.de>,
<jarkko.sakkinen@linux.intel.com>, <jgg@ziepe.ca>,
"Microsoft Linux Kernel List" <linux-kernel@microsoft.com>,
"Bryan Kelly (CSI)" <bryankel@microsoft.com>,
"Thirupathaiah Annapureddy" <thiruan@microsoft.com>,
"Sudhakar Evuri" <suredd@microsoft.com>, <arnd@arndb.de>,
<gregkh@linuxfoundation.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-integrity@vger.kernel.org>
Subject: Re: [PATCH 2/2] ftpm: firmware TPM running in TEE
Date: Tue, 2 Apr 2019 13:56:43 -0700 [thread overview]
Message-ID: <20190402135643.02443863@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190402193316.15144-2-sashal@kernel.org>
On Tue, 2 Apr 2019 12:33:16 -0700
"Sasha Levin" <sashal@kernel.org> wrote:
> +/*
> + * ftpm_tee_tpm_op_recv retrieve fTPM response.
> + * @param: chip, the tpm_chip description as specified in
> driver/char/tpm/tpm.h.
> + * @param: buf, the buffer to store data.
> + * @param: count, the number of bytes to read.
> + * @return: In case of success the number of bytes received.
> + * In other case, a < 0 value describing the issue.
> + */
You are using a docbook style comment but it doesn't start with
docbook prefix.
/**
* ftpm_tee_tpm_op_recv retrieve fTPM response.
*
* @param: chip, the tpm_chip description as specified in driver/char/tpm/tpm.h.
* @param: buf, the buffer to store data.
* @param: count, the number of bytes to read.
* @return: In case of success the number of bytes received.
* In other case, a < 0 value describing the issue.
*/
next prev parent reply other threads:[~2019-04-02 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 19:33 [PATCH 1/2] ftpm: dt-binding: add dts documentation for fTPM driver Sasha Levin
2019-04-02 19:33 ` [PATCH 2/2] ftpm: firmware TPM running in TEE Sasha Levin
2019-04-02 20:56 ` Stephen Hemminger [this message]
2019-04-03 18:19 ` Jarkko Sakkinen
2019-04-03 12:40 ` Jason Gunthorpe
2019-04-03 18:18 ` Jarkko Sakkinen
2019-04-03 18:27 ` Jarkko Sakkinen
2019-04-06 15:30 ` Sasha Levin
2019-04-10 11:29 ` Jarkko Sakkinen
2019-04-10 16:04 ` Sasha Levin
2019-04-10 17:38 ` Jarkko Sakkinen
2019-04-02 19:37 ` [PATCH 1/2] ftpm: dt-binding: add dts documentation for fTPM driver Greg KH
2019-04-02 20:03 ` Sasha Levin
2019-04-03 18:15 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402135643.02443863@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=arnd@arndb.de \
--cc=bryankel@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=sashal@kernel.org \
--cc=suredd@microsoft.com \
--cc=thiruan@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox