From: Sasha Levin <sashal@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
jgg@ziepe.ca, Mark Rutland <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
linux-integrity@vger.kernel.org, linux-kernel@microsoft.com,
thiruan@microsoft.com, bryankel@microsoft.com
Subject: Re: [PATCH v2 1/3] ftpm: dt-binding: add dts documentation for fTPM driver
Date: Wed, 10 Apr 2019 12:19:49 -0400 [thread overview]
Message-ID: <20190410161949.GC11568@sasha-vm> (raw)
In-Reply-To: <CAL_JsqLXcY9VFuY8xZvek0ybUXetS27jL-PW0XGLSVQR3Nc5aw@mail.gmail.com>
On Tue, Apr 09, 2019 at 04:18:29PM -0500, Rob Herring wrote:
>On Tue, Apr 9, 2019 at 1:50 PM Sasha Levin <sashal@kernel.org> wrote:
>>
>> The parameters are similar to the ones used by IBM's vTPM and the
>> various I2C tpm drivers.
>
>Bindings describe h/w (or firmware interfaces in this case), not drivers.
>
>>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>> .../bindings/security/tpm/tpm_ftpm_tee.txt | 13 +++++++++++++
>> .../devicetree/bindings/vendor-prefixes.txt | 1 +
>> 2 files changed, 14 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm_ftpm_tee.txt
>>
>> diff --git a/Documentation/devicetree/bindings/security/tpm/tpm_ftpm_tee.txt b/Documentation/devicetree/bindings/security/tpm/tpm_ftpm_tee.txt
>> new file mode 100644
>> index 000000000000..20fca67a56c4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/security/tpm/tpm_ftpm_tee.txt
>> @@ -0,0 +1,13 @@
>> +Required properties:
>> +- compatible: should be "microsoft,ftpm"
>> +- linux,sml-base: 64-bit base address of the reserved memory allocated
>> + for the firmware event log
>> +- linux,sml-size: size of the memory allocated for the firmware event log
>
>Firmware is defining linux specific properties? What if I want to run
>BSD? We should use 'reg' here instead.
This is based on already existing code that defines these names, see
tpm_read_log_of() in drivers/char/tpm/eventlog/of.c .
These properties were described similarily by other interfaces (see
Documentation/devicetree/bindings/security/tpm/ibmvtpm.txt or
Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt for example).
We could rename them all if you'd like, I was just trying to follow the
existing code.
>What memory is used here? This should be under /reserved-memory if it
>is part of "main" memory.
That's my understanding, yes.
>Really, I'd prefer to not see this in DT at all. Make the firmware
>discoverable. Why repeat the mistakes of non-discoverable h/w in s/w
>interfaces? OP-Tee at least has defined a mechanism to enumerate TEE
>functions IIRC.
Sadly the firmware already exists as-is on live hardware, there is a
paper describing it back from 2016 and we're stuck having to support
that.
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-04-10 16:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 18:49 [PATCH v2 0/3] ftpm: a firmware based TPM driver Sasha Levin
2019-04-09 18:49 ` [PATCH v2 1/3] ftpm: dt-binding: add dts documentation for fTPM driver Sasha Levin
2019-04-09 21:18 ` Rob Herring
2019-04-10 16:19 ` Sasha Levin [this message]
2019-04-10 17:01 ` Rob Herring
2019-04-10 17:03 ` Jason Gunthorpe
2019-04-10 17:53 ` Sasha Levin
2019-04-10 17:57 ` Jason Gunthorpe
2019-04-10 18:11 ` Thirupathaiah Annapureddy
2019-04-09 18:49 ` [PATCH v2 2/3] ftpm: firmware TPM running in TEE Sasha Levin
2019-04-09 19:22 ` Jason Gunthorpe
2019-04-09 18:49 ` [PATCH v2 3/3] ftpm: add documentation for ftpm driver Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410161949.GC11568@sasha-vm \
--to=sashal@kernel.org \
--cc=arnd@arndb.de \
--cc=bryankel@microsoft.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=thiruan@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).