From: Sasha Levin <sashal@kernel.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, corbet@lwn.net,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-kernel@microsoft.com,
thiruan@microsoft.com, bryankel@microsoft.com,
tee-dev@lists.linaro.org, ilias.apalodimas@linaro.org,
sumit.garg@linaro.org, rdunlap@infradead.org
Subject: Re: [PATCH v7 2/2] fTPM: add documentation for ftpm driver
Date: Wed, 26 Jun 2019 19:59:43 -0400 [thread overview]
Message-ID: <20190626235943.GM7898@sasha-vm> (raw)
In-Reply-To: <4bb41de0cd2b0bf89a20dd55576acf15594ae8de.camel@linux.intel.com>
On Thu, Jun 27, 2019 at 02:34:06AM +0300, Jarkko Sakkinen wrote:
>On Tue, 2019-06-25 at 16:13 -0400, Sasha Levin wrote:
>> This patch adds basic documentation to describe the new fTPM driver.
>>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>> Documentation/security/tpm/index.rst | 1 +
>> Documentation/security/tpm/tpm_ftpm_tee.rst | 31 +++++++++++++++++++++
>> 2 files changed, 32 insertions(+)
>> create mode 100644 Documentation/security/tpm/tpm_ftpm_tee.rst
>>
>> diff --git a/Documentation/security/tpm/index.rst
>> b/Documentation/security/tpm/index.rst
>> index af77a7bbb070..15783668644f 100644
>> --- a/Documentation/security/tpm/index.rst
>> +++ b/Documentation/security/tpm/index.rst
>> @@ -4,4 +4,5 @@ Trusted Platform Module documentation
>>
>> .. toctree::
>>
>> + tpm_ftpm_tee
>> tpm_vtpm_proxy
>> diff --git a/Documentation/security/tpm/tpm_ftpm_tee.rst
>> b/Documentation/security/tpm/tpm_ftpm_tee.rst
>> new file mode 100644
>> index 000000000000..48de0dcec0f6
>> --- /dev/null
>> +++ b/Documentation/security/tpm/tpm_ftpm_tee.rst
>> @@ -0,0 +1,31 @@
>> +=============================================
>> +Firmware TPM Driver
>> +=============================================
>> +
>> +| Authors:
>> +| Thirupathaiah Annapureddy <thiruan@microsoft.com>
>> +| Sasha Levin <sashal@kernel.org>
>
>The way I see it this thing should not exist here at all but the
>first patch should have co-developed-by in addition to
>signed-off-by from you. Otherwise looks good. The list of authors
>is againt something that Git does better than humans.
I've dropped this part, but left the co-developed tag out, I honestly
don't think that I had significant contribution here.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-06-26 23:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 20:13 [PATCH v7 0/2] fTPM: firmware TPM running in TEE Sasha Levin
2019-06-25 20:13 ` [PATCH v7 1/2] " Sasha Levin
2019-06-26 23:31 ` Jarkko Sakkinen
2019-06-26 23:56 ` Sasha Levin
2019-06-27 13:17 ` Jarkko Sakkinen
2019-06-27 13:19 ` Jarkko Sakkinen
2019-06-27 13:30 ` Ilias Apalodimas
2019-06-27 16:32 ` Jarkko Sakkinen
2019-07-02 14:21 ` Ilias Apalodimas
2019-07-02 16:54 ` Thirupathaiah Annapureddy
2019-07-03 6:58 ` Ilias Apalodimas
2019-07-03 8:12 ` Ilias Apalodimas
2019-07-03 10:03 ` Sumit Garg
2019-07-03 14:16 ` Joakim Bech
2019-07-04 6:28 ` Thirupathaiah Annapureddy
2019-07-04 18:11 ` Ilias Apalodimas
2019-07-05 2:40 ` Thirupathaiah Annapureddy
2019-07-10 12:13 ` Ilias Apalodimas
2019-06-28 5:50 ` Sumit Garg
2019-06-29 15:01 ` Sasha Levin
2019-07-04 9:20 ` Jarkko Sakkinen
2019-06-25 20:13 ` [PATCH v7 2/2] fTPM: add documentation for ftpm driver Sasha Levin
2019-06-25 23:13 ` Randy Dunlap
2019-06-26 23:34 ` Jarkko Sakkinen
2019-06-26 23:59 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626235943.GM7898@sasha-vm \
--to=sashal@kernel.org \
--cc=bryankel@microsoft.com \
--cc=corbet@lwn.net \
--cc=ilias.apalodimas@linaro.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=rdunlap@infradead.org \
--cc=sumit.garg@linaro.org \
--cc=tee-dev@lists.linaro.org \
--cc=thiruan@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).