Re: [PATCH 2/3] ima-evm-utils: Remove not needed argument from verify_hash_v2

[Vitaly Chikunov <vt@altlinux.org>]

Mimi,

On Thu, Jul 18, 2019 at 07:23:21PM -0400, Mimi Zohar wrote:
> On Fri, 2019-07-19 at 00:35 +0300, Vitaly Chikunov wrote:
> > Since we now always call verify_hash_v2() with NULL keyfile (assuming
> > all keys are already loaded into public_keys list), remove keyfile
> > argument and its handling from verify_hash_v2().
> > 
> > Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> 
> Thanks!
> 
> > ---
> >  src/libimaevm.c | 21 +++++++--------------
> >  1 file changed, 7 insertions(+), 14 deletions(-)
> > 
> > diff --git a/src/libimaevm.c b/src/libimaevm.c
> > index 97b7167..b153f1b 100644
> > --- a/src/libimaevm.c
> > +++ b/src/libimaevm.c
> > @@ -453,7 +453,7 @@ void init_public_keys(const char *keyfiles)
> >   * Return: 0 verification good, 1 verification bad, -1 error.
> >   */
> >  int verify_hash_v2(const char *file, const unsigned char *hash, int size,
> > -		   unsigned char *sig, int siglen, const char *keyfile)
> > +		   unsigned char *sig, int siglen)
> >  {
> 
> While making this change, could we also make both this and
> verify_hash_v1() functions static?

Yes, I wonder why they wasn't static in the first place.

> Should I make the change?

OK!

Thanks,