From: Petr Vorel <pvorel@suse.cz>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org
Subject: Re: [RFC PATCH] ima-evm-utils: Add some tests for evmctl
Date: Fri, 26 Jul 2019 15:07:08 +0200 [thread overview]
Message-ID: <20190726130708.GA4542@dell5510> (raw)
In-Reply-To: <20190725061855.3734-1-vt@altlinux.org>
Hi Vitaly,
generally LGTM, nice work!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
I'd be also for splitting the test into more commits (if possible).
Other suggestions:
* rename function names and variables to be more understandable
(e.g. a=$1 p=$2 h=$3 f=$4 isn't much readable).
* there should be some records in .gitignore
* rename tests/functions to tests/functions.sh
* I'd define exit codes (77, 99, ...) as variables
* Do you plan to use XFAIL:, XPASS: and ERROR: ? IMHO these are redundant.
* posix compatible shell code (does really arrays and 'declare -i'
and other bashisms needed?), but that'd take some effort, so it's up to you and Mimi.
IMHO posix shell syntax is easier to read.
Kind regards,
Petr
next prev parent reply other threads:[~2019-07-26 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 6:18 [RFC PATCH] ima-evm-utils: Add some tests for evmctl Vitaly Chikunov
2019-07-25 14:46 ` Mimi Zohar
2019-07-25 15:38 ` Vitaly Chikunov
2019-07-26 1:03 ` Mimi Zohar
2019-07-25 21:58 ` Bruno E. O. Meneguele
2019-07-25 22:31 ` Vitaly Chikunov
2019-07-26 13:07 ` Petr Vorel [this message]
2019-07-28 4:53 ` Vitaly Chikunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726130708.GA4542@dell5510 \
--to=pvorel@suse.cz \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=vt@altlinux.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).