From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9926C352AA for ; Wed, 2 Oct 2019 17:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 842DA2086A for ; Wed, 2 Oct 2019 17:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728485AbfJBRDS (ORCPT ); Wed, 2 Oct 2019 13:03:18 -0400 Received: from mga12.intel.com ([192.55.52.136]:32221 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728484AbfJBRDR (ORCPT ); Wed, 2 Oct 2019 13:03:17 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2019 10:03:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,249,1566889200"; d="scan'208";a="343386945" Received: from wkadry-mobl1.ger.corp.intel.com (HELO localhost) ([10.251.81.190]) by orsmga004.jf.intel.com with ESMTP; 02 Oct 2019 10:03:11 -0700 Date: Wed, 2 Oct 2019 20:03:10 +0300 From: Jarkko Sakkinen To: linux-integrity@vger.kernel.org Cc: Mimi Zohar , Jerry Snitselaar , James Bottomley , Sumit Garg , Stefan Berger , Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH v2,RESEND] tpm: Detach page allocation from tpm_buf Message-ID: <20191002170253.GA9634@linux.intel.com> References: <20191002104530.7679-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002104530.7679-1-jarkko.sakkinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Oct 02, 2019 at 01:45:30PM +0300, Jarkko Sakkinen wrote: > As has been seen recently, binding the buffer allocation and tpm_buf > together is sometimes far from optimal. The buffer might come from the > caller namely when tpm_send() is used by another subsystem. In addition we > can stability in call sites w/o rollback (e.g. power events)> > > Take allocation out of the tpm_buf framework and make it purely a wrapper > for the data buffer. OK, so the reason that the fix for the CC was not included, was that it was in my staging area. I had not amended it :-/ /Jarkko